Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Move src/components/utils into src/utils #1109

Merged
merged 8 commits into from
Sep 19, 2024
Merged
Show file tree
Hide file tree
Changes from 6 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .infra/rdev/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ stack:
services:
explorer:
image:
tag: sha-965c3509
tag: sha-542f7934
replicaCount: 1
env:
# env vars common to all deployment stages
Expand Down
10 changes: 5 additions & 5 deletions client/src/actions/index.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,9 @@
import { AnyAction } from "redux";
import {
storageGetTransient,
storageSetTransient,
} from "util/transientLocalStorage";
import { KEYS } from "util/localStorage";
import type { Config } from "../globals";
import * as globals from "../globals";
import { AnnoMatrixLoader, AnnoMatrixObsCrossfilter } from "../annoMatrix";
Expand All @@ -24,11 +29,6 @@ import type {
CellType,
} from "../common/types/entities";
import { postExplainNewTab } from "../components/framework/toasters";
import { KEYS } from "../components/util/localStorage";
import {
storageGetTransient,
storageSetTransient,
} from "../components/util/transientLocalStorage";
import { selectIsUserStateDirty } from "../selectors/global";
import { DataframeValue, LabelArray, LabelIndex } from "../util/dataframe";
import { packDiffExPdu, DiffExMode, DiffExArguments } from "../util/diffexpdu";
Expand Down
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
import React, { CSSProperties, cloneElement } from "react";
import { Tooltip } from "@blueprintjs/core";

import { tooltipHoverOpenDelayQuick } from "../../globals";
import { getFeatureFlag } from "../../util/featureFlags/featureFlags";
import { FEATURES } from "../../util/featureFlags/features";
import { getFeatureFlag } from "util/featureFlags/featureFlags";
import { FEATURES } from "util/featureFlags/features";
import { tooltipHoverOpenDelayQuick } from "~/globals";

const SPLIT_STYLE = {
display: "flex",
Expand Down
43 changes: 21 additions & 22 deletions client/src/components/app.tsx → client/src/components/App/App.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -2,28 +2,27 @@ import React from "react";
import { connect } from "react-redux";
import { ThemeProvider as EmotionThemeProvider } from "@emotion/react";
import { StyledEngineProvider, ThemeProvider } from "@mui/material/styles";
import { theme } from "./theme";
import BottomBanner from "./BottomBanner/BottomBanner";

import Controls from "./controls";
import DatasetSelector from "./datasetSelector/datasetSelector";
import Container from "./framework/container";
import Layout from "./framework/layout";
import LayoutSkeleton from "./framework/layoutSkeleton";
import LeftSideBar from "./leftSidebar";
import RightSideBar from "./rightSidebar";
import Legend from "./continuousLegend";
import MenuBar from "./menubar";
import Header from "./NavBar";
import actions from "../actions";
import { RootState, AppDispatch } from "../reducers";
import GlobalHotkeys from "./hotkeys";
import { selectIsSeamlessEnabled } from "../selectors/datasetMetadata";
import Graph from "./graph/graph";
import DiffexNotice from "./diffexNotice";
import Scatterplot from "./scatterplot/scatterplot";
import PanelEmbedding from "./PanelEmbedding";
import { BANNER_FEEDBACK_SURVEY_LINK } from "./BottomBanner/constants";
import actions from "actions";
import { RootState, AppDispatch } from "reducers";
import Controls from "common/components/Controls/Controls";
import { theme } from "util/theme";
import DatasetSelector from "components/DatasetSelectorTempFolder/DatasetSelector";
import DiffexNotice from "components/DiffexNoticeTempFolder/DiffexNotice";
import BottomBanner from "../BottomBanner/BottomBanner";
import Container from "../framework/container";
import Layout from "../framework/layout";
import LayoutSkeleton from "../framework/layoutSkeleton";
import LeftSideBar from "../leftSidebar";
import RightSideBar from "../rightSidebar";
import Legend from "../Legend/Legend";
import MenuBar from "../menubar";
import Header from "../NavBar";
import GlobalHotkeys from "../hotkeys";
import { selectIsSeamlessEnabled } from "../../selectors/datasetMetadata";
import Graph from "../graph/graph";
import Scatterplot from "../scatterplot/scatterplot";
import PanelEmbedding from "../PanelEmbedding";
import { BANNER_FEEDBACK_SURVEY_LINK } from "../BottomBanner/constants";

interface StateProps {
loading: RootState["controls"]["loading"];
Expand Down
2 changes: 1 addition & 1 deletion client/src/components/BottomBanner/style.ts
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import styled from "@emotion/styled";
import { Banner, Icon } from "@czi-sds/components";
import { beta100, beta400, gray500 } from "../theme";
import { beta100, beta400, gray500 } from "util/theme";

export const SKINNY_MODE_BREAKPOINT_WIDTH = 960;
export const BOTTOM_BANNER_ID = "bottom-banner";
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,15 +5,17 @@ import React, { FC, useEffect, useState } from "react";
import { connect } from "react-redux";

/* App dependencies */
import actions from "../../actions";
import { DatasetMetadata, Dataset } from "../../common/types/entities";
import DatasetMenu, { DatasetSelectedFn } from "./datasetMenu";
import { AppDispatch, RootState } from "../../reducers";
import { selectIsSeamlessEnabled } from "../../selectors/datasetMetadata";
import TruncatingBreadcrumb from "./truncatingBreadcrumb";
import actions from "actions";
import { DatasetMetadata, Dataset } from "common/types/entities";
import { AppDispatch, RootState } from "reducers";
import { selectIsSeamlessEnabled } from "selectors/datasetMetadata";
import DatasetMenu, {
DatasetSelectedFn,
} from "./components/DatasetMenu/DatasetMenu";
import TruncatingBreadcrumb from "./components/TruncatingBreadcrumb/TruncatingBreadcrumb";
import TruncatingBreadcrumbs, {
TruncatingBreadcrumbProps,
} from "./truncatingBreadcrumbs";
} from "./components/TruncatingBreadcrumbs/TruncatingBreadcrumbs";

/**
* Actions dispatched by dataset selector.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,12 +3,12 @@ import { Menu, MenuItem, Position, Popover } from "@blueprintjs/core";
import React from "react";

/* App dependencies */
import { Dataset } from "../../common/types/entities";
import { maxMenuItemCount } from "../../globals";
import { Dataset } from "common/types/entities";
import { maxMenuItemCount } from "~/globals";

/* Styles */
// @ts-expect-error --- TODO fix import
import styles from "./datasetSelector.css";
import styles from "../../datasetSelector.css";

/**
* Function invoked on select of dataset.
Expand Down
Original file line number Diff line number Diff line change
@@ -1,13 +1,10 @@
/* Core dependencies */
import { Breadcrumb } from "@blueprintjs/core";
import React from "react";

/* App dependencies */
import { TruncatingBreadcrumbProps } from "./truncatingBreadcrumbs";
import { TruncatingBreadcrumbProps } from "../TruncatingBreadcrumbs/TruncatingBreadcrumbs";

// Styles
// @ts-expect-error --- TODO fix import
import styles from "./datasetSelector.css";
import styles from "../../datasetSelector.css";

interface Props {
children?: React.ReactNode;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ import {
import React, { CSSProperties, useCallback, useEffect, useState } from "react";

/* App dependencies */
import Truncate from "../util/truncate";
import Truncate from "common/components/Truncate/Truncate";

interface Props {
breadcrumbRenderer: (item: TruncatingBreadcrumbProps) => JSX.Element;
Expand Down
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DatasetSelectorTempFolder

File renamed without changes.
Copy link
Contributor

@kaloster kaloster Sep 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DiffexNoticeTempFolder is this from interim renaming?

File renamed without changes.
Original file line number Diff line number Diff line change
Expand Up @@ -4,24 +4,24 @@ import { connect, shallowEqual } from "react-redux";
import * as d3 from "d3";
import { interpolateCool } from "d3-scale-chromatic";
import Async, { AsyncProps } from "react-async";
import { AppDispatch, RootState } from "../../reducers";

import {
createColorTable,
createColorQuery,
ColorTable,
ColorRange,
} from "../../util/stateManager/colorHelpers";
import { ColorsState } from "../../reducers/colors";
import { Genesets } from "../../reducers/genesets";
import * as globals from "../../globals";
} from "util/stateManager/colorHelpers";
import { ColorsState } from "reducers/colors";
import { Genesets } from "reducers/genesets";
import { AppDispatch, RootState } from "reducers";
import * as globals from "~/globals";

/**
* (thuang): The legend needs to be positioned below the cell count element
*/
const CELL_COUNT_ELEMENT_HEIGHT_PX = 20;

// create continuous color legend
// eslint-disable-next-line @typescript-eslint/no-explicit-any --- FIXME: disabled temporarily on migrate to TS.
const continuous = (selectorId: any, colorScale: any, colorAccessor: any) => {
const legendHeight = 200;
const legendWidth = 80;
Expand Down Expand Up @@ -150,6 +150,7 @@ const mapDispatchToProps = (dispatch: AppDispatch): DispatchProps => ({
type Props = StateProps & DispatchProps;

class ContinuousLegend extends React.Component<Props> {
// eslint-disable-next-line @typescript-eslint/no-explicit-any --- FIXME: disabled temporarily on migrate to TS.
static watchAsync(props: any, prevProps: any) {
return !shallowEqual(props.watchProps, prevProps.watchProps);
}
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import { Divider } from "@mui/material";
import styled from "@emotion/styled";
import { gray500 } from "../../../theme";
import { gray500 } from "util/theme";

export const NavDivider = styled(Divider)`
background-color: ${gray500};
Expand Down
6 changes: 3 additions & 3 deletions client/src/components/NavBar/style.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2,16 +2,16 @@ import { Classes } from "@blueprintjs/core";
import styled from "@emotion/styled";
import { css } from "@emotion/react";
import { Tag, CommonThemeProps, fontCapsXxxs } from "@czi-sds/components";
import { PT_TEXT_COLOR } from "./theme";
import { HEADER_HEIGHT_PX } from "../../globals";
import {
fontWeightBold,
fontWeightSemibold,
gray300,
gray500,
grayWhite,
spacesL,
} from "../theme";
} from "util/theme";
import { PT_TEXT_COLOR } from "./theme";
import { HEADER_HEIGHT_PX } from "~/globals";

export const Wrapper = styled.div`
background-color: ${PT_TEXT_COLOR};
Expand Down
9 changes: 4 additions & 5 deletions client/src/components/PanelEmbedding/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -2,14 +2,13 @@ import React, { useState } from "react";
import { connect } from "react-redux";
import { IconNames } from "@blueprintjs/icons";
import { Button } from "@blueprintjs/core";

import * as globals from "../../globals";
import Controls from "common/components/Controls/Controls";
import { AppDispatch, RootState } from "reducers";
import actions from "actions";
import * as globals from "~/globals";
import { height, width } from "./util";
import Graph from "../graph/graph";
import Controls from "../controls";
import Embedding from "../embedding";
import { AppDispatch, RootState } from "../../reducers";
import actions from "../../actions";
import { PANEL_EMBEDDING_MINIMIZE_TOGGLE_TEST_ID } from "./constants";

interface StateProps {
Expand Down
3 changes: 1 addition & 2 deletions client/src/components/categorical/category/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,8 @@ import { FaChevronRight, FaChevronDown } from "react-icons/fa";
import { Button, Classes, Position, Tooltip } from "@blueprintjs/core";
import Async, { AsyncProps } from "react-async";
import memoize from "memoize-one";

import Truncate from "common/components/Truncate/Truncate";
import Value from "../value";
import Truncate from "../../util/truncate";
import { CategoryCrossfilterContext } from "../categoryContext";

import * as globals from "../../../globals";
Expand Down
3 changes: 1 addition & 2 deletions client/src/components/categorical/value/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -2,11 +2,10 @@ import { connect } from "react-redux";
import React from "react";
import * as d3 from "d3";
import { Checkbox } from "@blueprintjs/core";
import Truncate from "common/components/Truncate/Truncate";
import * as globals from "../../../globals";
// @ts-expect-error ts-migrate(2307) FIXME: Cannot find module '../categorical.css' or its cor... Remove this comment to see the full error message
import styles from "../categorical.css";
import Truncate from "../../util/truncate";

import { AnnotationsHelpers } from "../../../util/stateManager";
import { labelPrompt, isLabelErroneous } from "../labelUtil";
import actions from "../../../actions";
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ import {
spacesS,
spacesXs,
textSecondary,
} from "../../../../../theme";
} from "util/theme";

export const Mark = styled.span`
color: ${textSecondary};
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import styled from "@emotion/styled";
import { spacesM, spacesS } from "../../../theme";
import { spacesM, spacesS } from "util/theme";

export const Wrapper = styled.div`
padding: ${spacesS}px ${spacesM}px;
Expand Down
2 changes: 1 addition & 1 deletion client/src/components/framework/layoutSkeleton.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import { SKELETON } from "@blueprintjs/core/lib/esnext/common/classes";
import React from "react";

/* App dependencies */
import Controls from "../controls";
import Controls from "common/components/Controls/Controls";
import Layout from "./layout";
import LeftSidebarSkeleton from "../leftSidebar/leftSidebarSkeleton";
import RightSidebarSkeleton from "../rightSidebar/rightSidebarSkeleton";
Expand Down
2 changes: 1 addition & 1 deletion client/src/components/geneExpression/gene/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -11,9 +11,9 @@ import {
import { EVENTS } from "analytics/events";
import { ActiveTab } from "common/types/entities";
import { InfoButton, InfoButtonWrapper } from "common/style";
import Truncate from "common/components/Truncate/Truncate";
import { State, Props, mapStateToProps, mapDispatchToProps } from "./types";
import { MINI_HISTOGRAM_WIDTH } from "../constants";
import Truncate from "../../util/truncate";

class Gene extends React.Component<Props, State> {
constructor(props: Props) {
Expand Down
2 changes: 1 addition & 1 deletion client/src/components/geneExpression/geneSet.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,8 @@ import { FaChevronRight, FaChevronDown } from "react-icons/fa";
import BrushableHistogram from "common/components/BrushableHistogram/BrushableHistogram";
import { track } from "analytics";
import { EVENTS } from "analytics/events";
import Truncate from "common/components/Truncate/Truncate";
import Gene from "./gene";
import Truncate from "../util/truncate";
import * as globals from "~/globals";
import GenesetMenus from "./menus/genesetMenus";
import EditGenesetNameDialogue from "./menus/editGenesetNameDialogue";
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,6 @@ import {
fontHeaderM,
} from "@czi-sds/components";
import { Icon } from "@blueprintjs/core";

import * as globals from "../../../../globals";
import * as styles from "../../util";
import {
fontWeightRegular,
fontWeightSemibold,
Expand All @@ -18,7 +15,9 @@ import {
spacesM,
warning100,
warning400,
} from "../../../theme";
} from "util/theme";
import * as styles from "../../util";
import * as globals from "~/globals";

export const InfoWrapper = styled.div`
display: flex;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ import { H3, HTMLTable, Classes } from "@blueprintjs/core";
import React, { CSSProperties } from "react";

// App dependencies
import Truncate from "common/components/Truncate/Truncate";
import {
Author,
Consortium,
Expand All @@ -12,7 +13,6 @@ import {
import { Category } from "../../../../common/types/schema";
import * as globals from "../../../../globals";
import { RootState } from "../../../../reducers";
import Truncate from "../../../util/truncate";

const COLLECTION_LINK_ORDER_BY = [
"DOI",
Expand Down
2 changes: 1 addition & 1 deletion client/src/components/geneExpression/infoPanel/style.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import styled from "@emotion/styled";
import { gray300 } from "../../theme";
import { gray300 } from "util/theme";

interface InfoPanelWrapperProps {
isHidden: boolean;
Expand Down
6 changes: 3 additions & 3 deletions client/src/components/menubar/style.ts
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import styled from "@emotion/styled";
import { spacesS } from "../theme";
import { getFeatureFlag } from "../../util/featureFlags/featureFlags";
import { FEATURES } from "../../util/featureFlags/features";
import { spacesS } from "util/theme";
import { getFeatureFlag } from "util/featureFlags/featureFlags";
import { FEATURES } from "util/featureFlags/features";

export const MAX_VERTICAL_THRESHOLD_WIDTH_PX = 500;
const isTest = getFeatureFlag(FEATURES.TEST);
Expand Down
2 changes: 1 addition & 1 deletion client/src/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ import { HotkeysProvider, FocusStyleManager } from "@blueprintjs/core";
import "./index.css";

/* our code */
import App from "./components/app";
import App from "./components/App/App";
import store from "./reducers";

/**
Expand Down
2 changes: 1 addition & 1 deletion client/src/util/featureFlags/featureFlags.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { storageGet, storageSet } from "../../components/util/localStorage";
import { storageGet, storageSet } from "util/localStorage";
import { FEATURES } from "./features";

const FEATURE_FLAG_PREFIX = "cxg-ff-";
Expand Down
File renamed without changes.
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { DataPortalProps } from "../../common/types/entities";
import { DataPortalProps } from "common/types/entities";

const VERSION_ONES = ["1.0.0", "1.1.0"];
const VERSION_TWOS = ["2.0.0"];
Expand Down
Loading