feat: 88 add dataset_id to the metadata endpoint (#93)

Co-authored-by: Timmy Huang <[email protected]>
chanzuckerberg · Sep 30, 2021 · ae60d1b · ae60d1b
1 parent 24d7b63
commit ae60d1b
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 0 deletions.
diff --git a/server/data_common/dataset_metadata.py b/server/data_common/dataset_metadata.py
@@ -126,6 +126,7 @@ def get_dataset_and_collection_metadata(dataset_explorer_location: str, app_conf
 
             metadata = {
                 "dataset_name": [dataset["name"] for dataset in res["datasets"] if dataset["id"] == dataset_id][0],
+                "dataset_id": dataset_id,
                 "collection_url": f"{web_base_url}/collections/{collection_id}{suffix}",
                 "collection_name": res["name"],
                 "collection_description": res["description"],

diff --git a/server/tests/unit/common/test_api.py b/server/tests/unit/common/test_api.py
@@ -805,6 +805,7 @@ def test_dataset_metadata_api_called(self, mock_get, mock_dp):
         self.assertEqual(response_obj["dataset_name"], "Test Dataset")
 
         expected_url = f"https://cellxgene.staging.single-cell.czi.technology/collections/{response_body['id']}"
+        self.assertEqual(response_obj["dataset_id"], response_body["datasets"][0]["id"])
         self.assertEqual(response_obj["collection_url"], expected_url)
         self.assertEqual(response_obj["collection_name"], response_body["name"])
         self.assertEqual(response_obj["collection_contact_email"], response_body["contact_email"])