Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add code for validating fragement file #1095

Merged
merged 40 commits into from
Feb 18, 2025
Merged
Show file tree
Hide file tree
Changes from 31 commits
Commits
Show all changes
40 commits
Select commit Hold shift + click to select a range
9f3b9bd
Add prototype code for validating fragement file
Bento007 Nov 14, 2024
e17c153
print errors and exit with 1
Bento007 Nov 14, 2024
94b6ab1
cleaning up the code and making sure it runs
Bento007 Nov 14, 2024
5743033
add test for the atac_seq process and test data.
Bento007 Nov 14, 2024
c160738
Merge branch 'main' into tsmith/10x-ATAC
Bento007 Nov 18, 2024
a59d7b2
- use logger
Bento007 Nov 18, 2024
59dc3d0
fix logical error when validating
Bento007 Nov 18, 2024
0b6debd
Merge branch 'main' into tsmith/10x-ATAC
Bento007 Nov 20, 2024
5013642
remove compute from validate because it's not used
Bento007 Nov 20, 2024
197558e
check fragment files exists before uppacking in cli
Bento007 Nov 20, 2024
d95b1cc
add TestValidateFragmentBarcodeInAdataIndex
Bento007 Nov 20, 2024
1d30722
stop coordinate is <= chromosome length
Bento007 Nov 22, 2024
bc8f8f3
Merge branch 'main' into tsmith/10x-ATAC
Bento007 Jan 22, 2025
e6be307
adding todos
Bento007 Jan 25, 2025
5e4091a
Merge branch 'refs/heads/main' into tsmith/10x-ATAC
Bento007 Feb 11, 2025
c95d7d9
add additional unit tests for validation steps
Bento007 Feb 11, 2025
742cca6
Add validation steps for validate_anndata_is_atac, validate_anndata_f…
Bento007 Feb 12, 2025
d0ae8b9
fix typing
Bento007 Feb 12, 2025
873a155
add one more check
Bento007 Feb 12, 2025
c2ac0f2
additional testing for generate bgzip and tbi files
Bento007 Feb 13, 2025
9cd400a
- parameterize test_process_fragment to use all write methods
Bento007 Feb 13, 2025
a7bb52d
- install libbz2-dev
Bento007 Feb 13, 2025
0ffad8c
install liblzma-dev
Bento007 Feb 13, 2025
f7d5b07
Update .github/workflows/push_tests.yml
Bento007 Feb 14, 2025
2c6788b
install in ~/bin
Bento007 Feb 14, 2025
46ed1ac
install in /user/bin
Bento007 Feb 14, 2025
e29f1df
sudo
Bento007 Feb 14, 2025
536285b
Update cellxgene_schema_cli/tests/test_atac_seq.py
Bento007 Feb 14, 2025
d074190
find bgzip
Bento007 Feb 14, 2025
df1cb0c
add make
Bento007 Feb 14, 2025
38f8afd
apt-get
Bento007 Feb 14, 2025
bc6aae8
add test for processing bgz and gz files
Bento007 Feb 15, 2025
3912142
split test_process_fragment tests
Bento007 Feb 18, 2025
d734df3
install tabix
Bento007 Feb 18, 2025
ecf27d6
Update cellxgene_schema_cli/cellxgene_schema/atac_seq.py
Bento007 Feb 18, 2025
c1de0fe
Merge branch 'main' into tsmith/10x-ATAC
Bento007 Feb 18, 2025
b6574c2
add a separate check to see if fragment validation is needed.
Bento007 Feb 18, 2025
11c70be
fix check-anndata-requires-fragment help message
Bento007 Feb 18, 2025
9ab692f
add TestValidateFragmentStopCoordinateWithinChromosome.test_organism_…
Bento007 Feb 18, 2025
acafea5
use inline pytest.raises(...,match=)
Bento007 Feb 18, 2025
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .github/workflows/push_tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,9 @@ jobs:
run: |
pip install -r ./requirements-dev.txt
pip install -e ./cellxgene_schema_cli

sudo apt-get update
sudo apt-get install libbz2-dev liblzma-dev samtools
- name: cellxgene_schema_cli Unit tests
run: make unit-test
- name: Upload coverage results as an artifact
Expand Down
1 change: 1 addition & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@ venv/

# Include h5ads in tests
!cellxgene_schema_cli/tests/fixtures/h5ads/*
!cellxgene_schema_cli/tests/fixtures/atac_seq/*

# Kozareva big files
cb_annotated_object.RDS
Expand Down
Loading
Loading