SDS Spacing Refactor #609
Merged
SDS Spacing Refactor #609
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nclack
reviewed
Jul 18, 2022
| @@ -42,7 +42,9 @@ exports[`<PluginComplexFilter /> should match snapshot 1`] = ` | |||
| class="MuiTouchRipple-root" | |||
| /> | |||
| </button> | |||
| <div> | |||
| <div | |||
| class="css-1flrym7" | |||
There was a problem hiding this comment.
this is automatically generated at runtime for testing UIs against a snapshot
nclack
reviewed
Jul 18, 2022
| @@ -90,8 +90,8 @@ export function AppBarLanding() { | |||
| </div> | |||
|
|
|||
| {/* Render as separate list so that it renders below everything on smaller screens. */} | |||
| <div className="screen-725:hidden"> | |||
| <List className="col-span-2 px-6 mt-4"> | |||
| <div className="col-span-2 screen-725:hidden"> | |||
There was a problem hiding this comment.
ahh there was a refactor I made in the past that put the col-span-2 on the wrong div, so I'm fixing that here since it's just a tailwind class I have to move
nclack
approved these changes
Jul 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactors napari hub margins, paddings, and gaps to use the SDS spacing scale defined here. Ultimately, there should be no major changes in site functionality. Spacing might be a little different, but it should be barely noticeable (except maybe by a designer 🧑🎨)
https://napari-hub-sds-spacing.vercel.app