Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix link to plugin guide #558

Merged
merged 1 commit into from
Jun 21, 2022
Merged

Conversation

dchudz
Copy link
Contributor

@dchudz dchudz commented Jun 15, 2022

The existing link to the plugin tutorial (https://napari.org/plugins/stable/for_plugin_developers.html#plugins-for-plugin-developers) is a 404. (I'm guessing it's a tutorial on the old plugin engine, and was renamed/removed.)

This changes the link to https://napari.org/plugins/.

I also made some small language changes, which I'm not attached to (happy to tweak however folks want, or abandon this PR and let someone else fix the link), but here's an explanation:

  • changed "tutorial" to "documentation" since npe2 doesn't seem to have a "tutorial" exactly
  • removed "hook" since that word doesn't seem to be used in npe2.

Here's a screenshot after my changes:

Screen Shot 2022-06-15 at 10 27 10 AM

@dchudz dchudz marked this pull request as ready for review June 15, 2022 14:38
Copy link
Contributor

@justinelarsen justinelarsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix @dchudz ! It looks great to me. What do you think @neuromusic @codemonkey800 ?

@neuromusic
Copy link
Collaborator

awesome, thanks for catching this @dchudz !!

Copy link
Collaborator

@codemonkey800 codemonkey800 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@dchudz
Copy link
Contributor Author

dchudz commented Jun 21, 2022

Is anything in the way of merging this?

@neuromusic
Copy link
Collaborator

@dchudz: thanks for following up. no, I think we're good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants