Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Analytics for create a new collection #554

Merged
merged 5 commits into from
Jun 22, 2022

Conversation

codemonkey800
Copy link
Collaborator

Closes #513

@codemonkey800 codemonkey800 force-pushed the jeremy/collections-analytics branch from bae95f0 to 4ca88bf Compare June 14, 2022 19:52
Copy link
Collaborator

@neuromusic neuromusic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, however, the plausible "goals" are getting a bit unwieldy. we should consider a naming convention for better tracking. proposed a revision to this goal here (but requires change in plausible, too)

@codemonkey800 codemonkey800 requested a review from neuromusic June 16, 2022 17:10
@@ -54,6 +54,8 @@ export type Events = {
url: string;
categoryDimension: string;
};

'CTA: New Collection': unknown;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does "unknown" signify here?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this represents the type of the data payload for the event. for example, here's what it is for filters:

Filter: {
field: string;
value: string;
checked: boolean;
};

since the only thing we need from this event is whether it was fired or not, we don't really need a payload type, so I passed in unknown for now. check this out for more info on the unknown type: https://www.typescriptlang.org/docs/handbook/release-notes/typescript-3-0.html#new-unknown-top-type

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah makes sense! Thanks for the overview!

Base automatically changed from jeremy/social-preview-metadata to main June 22, 2022 20:40
@codemonkey800 codemonkey800 merged commit 0050144 into main Jun 22, 2022
@codemonkey800 codemonkey800 deleted the jeremy/collections-analytics branch June 22, 2022 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

P1 - Plausible Analytics for collections
3 participants