Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backend NPE2 Feature #520

Merged
merged 132 commits into from
Jun 15, 2022
Merged

Backend NPE2 Feature #520

merged 132 commits into from
Jun 15, 2022

Conversation

klai95
Copy link
Contributor

@klai95 klai95 commented Jun 1, 2022

Description: The new napari plugin specification (npe2) provides a reliable way for plugin developers to explicitly declare information about their plugin, such as a human-readable display name or which file extensions the plugin can load. While the primary goal of this new interface is to improve napari, some of this metadata is also useful to napari users who are searching for plugins & we want to help users. This pull request surfaces metadata for plugins (npe1 and npe2) for the napari plugin ecosystem.

Product Requirements Document: https://czi.quip.com/rloYAqqLEm59/PRD-Activity-Dashboard

Project Link: https://github.com/orgs/chanzuckerberg/projects/12

Screenshot: Screen Shot 2022-06-14 at 8 19 07 PM

Technical Specification: https://docs.google.com/document/d/1JWm-71Ak6T85pEbO5g9EOJgm-PMR9LLzLwgqG1vpLL4/edit#heading=h.i83ttmuejrpb

@codemonkey800
Copy link
Collaborator

@potating-potato @klai95 you can check for npe2 using this URL:

https://add-npe2-lambda-frontend.dev.imaging.cziscience.com/plugins/affinder?enable-feature=npe2

however, I do not see any plugin data in the frontend or API 🤔

image

image

backend/utils/utils.py Outdated Show resolved Hide resolved
Copy link
Contributor

@liu-ziyang liu-ziyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need to update the exception message

@klai95
Copy link
Contributor Author

klai95 commented Jun 14, 2022

need to update the exception message

can you clarify what we need to update with the exception message itself? Right now we have process_count and error_message

@liu-ziyang
Copy link
Contributor

need to update the exception message

can you clarify what we need to update with the exception message itself? Right now we have process_count and error_message

https://github.com/chanzuckerberg/napari-hub/pull/520/files#r896239190

@liu-ziyang
Copy link
Contributor

liu-ziyang commented Jun 14, 2022

however, I do not see any plugin data in the frontend or API 🤔

@codemonkey800
they maybe emptying data to test the update mechanism, right now the manifest API is outputting https://6vwmwypt38.execute-api.us-west-2.amazonaws.com/dev-add-npe2-lambda/manifest/affinder

same for the https://6vwmwypt38.execute-api.us-west-2.amazonaws.com/dev-add-npe2-lambda/plugins/affinder

@klai95 the manifest API is not outputting format to be application/yaml, it is showing text/html hence the rendering is weird

backend/api/app.py Outdated Show resolved Hide resolved
@klai95
Copy link
Contributor Author

klai95 commented Jun 15, 2022

@potating-potato @klai95 you can check for npe2 using this URL:

https://add-npe2-lambda-frontend.dev.imaging.cziscience.com/plugins/affinder?enable-feature=npe2

however, I do not see any plugin data in the frontend or API 🤔

image image

Updated frontend link: https://dev-add-npe2-lambda-frontend.dev.imaging.cziscience.com/plugins/affinder?enable-feature=npe2

@klai95 klai95 enabled auto-merge (squash) June 15, 2022 03:28
@klai95 klai95 merged commit b9203f1 into main Jun 15, 2022
@klai95 klai95 deleted the dev-add-npe2-lambda branch June 15, 2022 03:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants