Fix plugin metadata IDs #453
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codemonkey800
commented
Mar 31, 2022
| @@ -42,9 +42,10 @@ export function MetadataList({ | |||
| Use list wrapper so that the preview highlight overlay only renders as | |||
| tall as the content. | |||
| */} | |||
| <div id={id} className={clsx('text-sm', className)}> | |||
There was a problem hiding this comment.
here's the reason why we had duplicate IDs lol
codemonkey800
requested review from
justinelarsen,
neuromusic,
kne42 and
klai95
This was
linked to
issues
Mar 31, 2022
Closed
codemonkey800
commented
Mar 31, 2022
| @@ -157,7 +158,7 @@ function PluginMetadataBase({ | |||
| className="h-56" | |||
| render={() => ( | |||
| <> | |||
| {renderSingleItemList('version', { highlight: false })} | |||
| {renderSingleItemList('version')} | |||
There was a problem hiding this comment.
I noticed that the version wasn't being highlighted for some reason, I must have mistakenly added this highlight: false to this field. Since the plugin version is a part of the required metadata for the preview page, I re-enabled highlighting for this field.
codemonkey800
commented
Mar 31, 2022
| @@ -275,3 +275,5 @@ export type MetadataKeys = keyof Omit< | |||
| Metadata, | |||
| 'actionRepository' | 'workflowSteps' | 'imageModality' | 'supportedData' | |||
| >; | |||
|
|
|||
| export type MetadataId = `metadata-${MetadataKeys}`; | |||
There was a problem hiding this comment.
This uses the new template literal types from TypeScript 4.1:
https://www.typescriptlang.org/docs/handbook/2/template-literal-types.html
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes:
This works by adding a the prefix
metadata-to plugin metadata IDs.FYI: @justinelarsen @neuromusic
For review: @klai95 @kne42