Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API access time improvements #424

Merged
merged 2 commits into from
Feb 9, 2022
Merged

API access time improvements #424

merged 2 commits into from
Feb 9, 2022

Conversation

liu-ziyang
Copy link
Contributor

according to our metrics, the head call takes longer than data fetch...

@liu-ziyang liu-ziyang requested a review from klai95 February 9, 2022 00:40
@@ -16,11 +16,9 @@ resource aws_api_gateway_stage api_stage {
resource aws_api_gateway_method_settings api_gateway_stage_setting {
rest_api_id = var.rest_api_id
stage_name = aws_api_gateway_stage.api_stage.stage_name
method_path = "*/*"
method_path = "{proxy+}/GET"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

enables cache on GET request, previously we do not override any configuration

Copy link
Collaborator

@codemonkey800 codemonkey800 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@liu-ziyang liu-ziyang merged commit 1fa522a into main Feb 9, 2022
@liu-ziyang liu-ziyang deleted the dev-improve-s3-access-time branch February 9, 2022 02:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants