add datadog integration #398
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codemonkey800
approved these changes
Jan 24, 2022
Comment on lines
+8
to
+9
| ENV DD_LAMBDA_HANDLER="api.app.handler" | ||
| ENV DD_TRACE_ENABLED="true" |
There was a problem hiding this comment.
is this used by datadog for tracing? might be nice to add documentation about it 😄
There was a problem hiding this comment.
the docs is here: https://docs.datadoghq.com/serverless/installation/python/?tab=containerimage
I think we may want to include the doc in a central place, let me think about this
klai95
reviewed
Jan 24, 2022
| @@ -5,10 +5,11 @@ flask-githubapp | |||
| gunicorn[gevent] | |||
| pyyaml | |||
| requests | |||
| markdown==3.3.4 | |||
| markdown | |||
There was a problem hiding this comment.
What's the rationale behind this code change?
There was a problem hiding this comment.
the binning was because a bug in markdown, I helped patched this upstream, I thought I removed the binning but apparently not, just sneaking it back in now
klai95
approved these changes
Jan 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds datadog integration to backend lambda.
The default integration allows datadog to report metrics like invoking time and aws s3 request times.
In terms of custom metrics, currently it is tracking plugin counts, but we can build other metrics on top of it