Frontend i18n #382
Merged
Frontend i18n #382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been linked to Shortcut Story #176695: Intl integration. |
This was referenced Jan 7, 2022
|
The main advantages to having this are:
|
…383) * next-i18next setup * i18n type definitions * I18n component * i18n for pages * i18n for error pages * i18n for MDX files * Update snapshots * Fix type errors * Frontend i18n - Refactor hub strings (#384) * i18n for common components * i18n for AppBar * i18n for CategoryChip * i18n for Footer * i18n for MetadataHighlighter * i18n for MetadataList * i18n for PluginDetails * i18n for PluginSearch * i18n for SearchBar * i18n for SignupForm * Fix lint errors * Mock i18n helpers for testing * Mock i18n strings for I18n component * Fix type error * Fix e2e test errors * Fix plugin details layout for preview * Added getSections() for typing * Change to absolute import * Fix GH checks errors * i18n for page metadata * Fixed i18n not working for page metadata * Disable rendering PageMetadata for preview page * Fix page metadata for MDX pages * Refactor i18n types
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR along with several other PRs implement i18n for the frontend of the napari hub. This works by using both Next.js' Internationalized Routing Feature, and the excellent i18n library next-i18next for managing i18n state.
Release Plan
The implementation is split into separate PRs to make it easier to review. When all the PRs are reviewed and ready to merge, I'll merge them one by one into each other until all dependent PRs are merged into this one. Finally, I'll merge this PR to push the i18n feature to staging.
Pull Requests
Demos
English
https://i18n-test-frontend.dev.imaging.cziscience.com
If everything is working correctly, there should be no noticeable difference since it's an underlying change.
Spanish
https://i18n-test-frontend.dev.imaging.cziscience.com/es
This version uses text translated using Google Translate for demonstration.