Remove Material UI import babel transformation #322
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This removes the buggy babel transformation for Material UI imports. We originally used this so that we could improve build performance while using root imports like
import { Accordion, Button } from '@material-ui/core'
. However, this has proven to be very buggy (and occasionally blocking) for developers due to intermittent errors related to default exports:With no clear solution in sight, and with Next.js removing babel in the v12 release, this PR refactors the imports to import from the module directly instead of from the root import.
This also adds an eslint plugin that verifies that root imports aren't being used in the app, so using the following imports will now throw an eslint error:
Demo