Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Category UI state #316
Category UI state #316
Changes from all commits
2bbb136
9a554dd
3a0c1e8
f6e8907
7afafbb
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would the triple for loop become a performance bottleneck? I am not sure if there is a way to get around it, but just wanted to get some clarity on this!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great feedback! 🤩
It could be if the amount of categories and category keys increase a lot. That would be basically
O(NMK)
🤣 I can't think of a better way at the moment since:N
plugins.M
categories.K
keys so we can populate the form state.There's no way around this because we need to figure out the entire set of keys possible, and the only way to do that is by looking at every key for every category for every plugin.
I'm not too worried also because our existing category datasets are small, and we are eventually planning to move the search to the backend so that user's don't have to compute this on their devices