Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

only set citation value when valid citation presents #301

Merged
merged 1 commit into from
Oct 25, 2021

Conversation

liu-ziyang
Copy link
Contributor

reformat citation data per frontend request: only store citation value when valid

@liu-ziyang liu-ziyang requested a review from kne42 October 25, 2021 18:54
Copy link
Member

@kne42 kne42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome, thank you!

@liu-ziyang liu-ziyang merged commit c83e89c into main Oct 25, 2021
@liu-ziyang liu-ziyang deleted the reformat-citation-data branch October 25, 2021 21:48
kne42 added a commit that referenced this pull request Oct 26, 2021
* main: (43 commits)
  use html mime for index.html
  update s3 cache location (#304)
  Preview page base path (#302)
  Preview page metadata highlighting (#291)
  Update nvmrc to use Node.js v16 (#303)
  only set citation value when valid citation presents (#301)
  Dev GitHub preview app (#294)
  napari hub bug fixes (#290)
  Increase z-index for sticky preview bar (#293)
  Bump browserslist from 4.16.3 to 4.16.6 in /frontend (#292)
  Updates frontend dependencies (#288)
  Remove dates from preview page (#289)
  Update absolute imports for preview package
  fix module importing with absolute import
  fix module importing with absolute import
  update docker command
  Preview page app bar (#276)
  addressed provisioned lambda count default
  Fix get_preview import
  just move dockerfile out
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants