Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add handling for 404 message specifically #278

Merged
merged 1 commit into from
Oct 7, 2021
Merged

Conversation

liu-ziyang
Copy link
Contributor

Handling common 404 NOT FOUND issue when invalid endpoint is used to access the API

@liu-ziyang liu-ziyang requested a review from klai95 October 7, 2021 00:08
@liu-ziyang
Copy link
Contributor Author

tested working on dev

Screen Shot 2021-10-06 at 5 15 14 PM

Copy link
Contributor

@klai95 klai95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Collaborator

@codemonkey800 codemonkey800 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! it would be nice if it was possible to log what endpoint is being hit, but reading the flask docs, i'm not sure if it's possible lol 🍜

@liu-ziyang
Copy link
Contributor Author

LGTM! it would be nice if it was possible to log what endpoint is being hit, but reading the flask docs, i'm not sure if it's possible lol 🍜

very likely it would be a typo from the user or some robot access. Either case I override the endpoint to return the list of available plugins to be more useful to actual users

@liu-ziyang liu-ziyang merged commit 42d8619 into main Oct 7, 2021
@liu-ziyang liu-ziyang deleted the dev-handling-404 branch October 14, 2021 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants