Fix page out-of-range check #277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codemonkey800
force-pushed
the
jeremy/fix-pagination-out-of-range-issues
branch
from
8875076 to
6febf90
Compare
klai95
reviewed
Oct 6, 2021
| * @param totalPages The max number of pages allowed. | ||
| */ | ||
| function setPageState(totalPages: number) { | ||
| if (page > totalPages) { |
There was a problem hiding this comment.
is page zero-indexed or one-indexed?
There was a problem hiding this comment.
love the question! pages are one-indexed 😆 if this was a programmer website, maybe it would have been zero-indexed lol
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This fixes an issue with the page out-of-range check not working when the results are reduced using the search query or plugin filters.
Initially the
totalPageswas being calculated using:However, when there's a search query or if a filter is enabled, the actual total may be less than the calculated amount. Because of this, the only way to get the correct
totalPagesvalue is to read the derived state.Demo
Before
Visiting https://staging.napari-hub.org/?search=image&sort=relevance&page=5 will open a page with empty results. The page will also be out of range:
After
Visiting https://pagination-frontend.dev.imaging.cziscience.com/?search=image&sort=relevance&page=5 will now correctly change the page to
4.