add citation parsing for different formats #229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been linked to Clubhouse Story #151021: Easy citation data fetching. |
kne42
approved these changes
Aug 9, 2021
backend/napari.py
Outdated
| extra_metadata['citation'] = citation | ||
| citation_file = get_file(download_url, "CITATION.cff") | ||
| if citation_file is not None: | ||
| extra_metadata['citations'] = (get_citation(citation_file)) |
There was a problem hiding this comment.
why is the get_citation call wrapped in parentheses?
backend/napari.py
Outdated
|
|
||
| return extra_metadata | ||
|
|
||
|
|
||
| def get_citation(citation_str: str) -> dict: |
There was a problem hiding this comment.
I find it weird that this is named get_citation (singular) as opposed to get_citations (plural) since it is referred to in plural for everywhere else
There was a problem hiding this comment.
nice catch! it should have been renamed to accommodate the dictionary
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added parsing of citation into RIS and BibTex format, pending on APA format on discussion here: citation-file-format/cffconvert#157