Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update to storybook 8 #2003

Merged
merged 1 commit into from
Jul 1, 2024
Merged

chore: update to storybook 8 #2003

merged 1 commit into from
Jul 1, 2024

Conversation

booc0mtaco
Copy link
Contributor

  • update docs to support storybook 8 semantics
  • fix documentation issues for hiding react nodes for children props
  • configure plugins to mesh with new conventions

Test Plan:

  • Wrote automated tests
  • CI tests / new tests are not applicable
  • Manually tested my changes, but I want to keep the details secret
  • Created and used an alpha publish
  • Manually tested my changes, and here are the details:

@booc0mtaco booc0mtaco requested a review from a team as a code owner June 28, 2024 18:11
@booc0mtaco
Copy link
Contributor Author

Screenshot 2024-06-28 at 11 12 32

This has happened the last few times we updated storybook... some change causes tests which ran normally to suddenly start emitting noise.

@booc0mtaco booc0mtaco force-pushed the aholloway/x-update-storybook branch from 7e06867 to c895220 Compare June 28, 2024 18:25
@codecov Codecov
Copy link

codecov bot commented Jun 28, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.52%. Comparing base (8284fb5) to head (18adb74).

Additional details and impacted files 
@@           Coverage Diff           @@
##             next    #2003   +/-   ##
=======================================
  Coverage   97.52%   97.52%           
=======================================
  Files         108      108           
  Lines        2545     2545           
  Branches      635      635           
=======================================
  Hits         2482     2482           
  Misses         61       61           
  Partials        2        2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@booc0mtaco booc0mtaco force-pushed the aholloway/x-update-storybook branch 2 times, most recently from f48d0a7 to a81f28c Compare June 28, 2024 19:46
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 28, 2024 •
edited
Loading

size-limit report 📦

Path Size
components 87.48 KB (-0.02% 🔽)
styles 27.65 KB (0%)

@booc0mtaco booc0mtaco force-pushed the aholloway/x-update-storybook branch from a81f28c to 77efc1d Compare June 28, 2024 19:56
@booc0mtaco
chore: update to storybook 8
18adb74 
- update docs to support storybook 8 semantics
- update commands in package.json to latest supported behaviors
- fix documentation issues for hiding react nodes for children props
- configure plugins to mesh with new conventions
- update typescript to latest version
- see storybookjs/storybook#26586
@booc0mtaco booc0mtaco force-pushed the aholloway/x-update-storybook branch from 77efc1d to 18adb74 Compare June 28, 2024 20:11
@booc0mtaco
Copy link
Contributor Author

Screenshot 2024-06-28 at 11 12 32

This has happened the last few times we updated storybook... some change causes tests which ran normally to suddenly start emitting noise.

There is some difference between @storybook/test and @storybook/testing-library which leads to these act warnings being generated. There is a migration that makes this change in the repo, which is why it has cropped up a few times in the past. Restoring the dependency and using @storybook/testing-library fixes the outputted warnings without requiring any tests to be changed

booc0mtaco
booc0mtaco commented Jun 28, 2024
View reviewed changes
package.json
@@ -44,7 +44,7 @@
"build:clean": "rm -rf lib/",
"build:tokens": "rm -rf src/tokens-dist/ && node ./style-dictionary.config.js && yarn prettier-tokens-dist",
"build:js": "rollup --config",
"build:storybook": "storybook build -o storybook-static -s src/design-tokens/tier-1-definitions/fonts",
"build:storybook": "storybook build -o storybook-static",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed that the fonts get fetched in the UI without this being added

@booc0mtaco booc0mtaco mentioned this pull request Jul 1, 2024
Merged
1 task
@booc0mtaco booc0mtaco merged commit 36754d1 into next Jul 1, 2024
10 checks passed
@booc0mtaco booc0mtaco deleted the aholloway/x-update-storybook branch July 1, 2024 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahuth ahuth ahuth approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@booc0mtaco @ahuth