Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(FieldNote): adjust layout for icon and text lockup #1961

Merged
merged 2 commits into from
May 23, 2024

Conversation

booc0mtaco
Copy link
Contributor

Test Plan:

  • update chromatic snapshots
  • Wrote automated tests
  • CI tests / new tests are not applicable
  • Manually tested my changes, but I want to keep the details secret
  • Created and used an alpha publish
  • Manually tested my changes, and here are the details:

Copy link

codecov bot commented May 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.74%. Comparing base (402e433) to head (90c07e0).

Additional details and impacted files
@@                 Coverage Diff                 @@
##           v15-components-2.0    #1961   +/-   ##
===================================================
  Coverage               96.74%   96.74%           
===================================================
  Files                     137      137           
  Lines                    3437     3437           
  Branches                  929      929           
===================================================
  Hits                     3325     3325           
  Misses                    109      109           
  Partials                    3        3           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@booc0mtaco booc0mtaco merged commit 66b9bed into v15-components-2.0 May 23, 2024
9 checks passed
@booc0mtaco booc0mtaco deleted the aholloway/EDS-1328 branch May 23, 2024 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant