feat(Button)!: introduce button v2.0 #1886
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
booc0mtaco
force-pushed
the
aholloway/EDS-1136
branch
from
4ef10fe to
0c9daf8
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## v15-components-2.0 #1886 +/- ##
===================================================
Coverage 97.16% 97.16%
===================================================
Files 106 106
Lines 2330 2330
Branches 546 546
===================================================
Hits 2264 2264
Misses 64 64
Partials 2 2 ☔ View full report in Codecov by Sentry. |
booc0mtaco
commented
Mar 12, 2024
| @@ -6,7 +6,7 @@ import { SIZES, STATUSES } from '../ClickableStyle'; | |||
| import Icon from '../Icon'; | |||
|
|
|||
| export default { | |||
| title: 'Components/Button', | |||
| title: 'Components/Button (v1)', | |||
There was a problem hiding this comment.
Keeping the v1 versions of components around, so that it is easy to do comparisons and avoid snapshot change noise. Once all the component batches are completed, will remove the old versions and annotate the changes between the two.
booc0mtaco
force-pushed
the
aholloway/EDS-1136
branch
from
0c9daf8 to
a41a821
Compare
- completely rebuild component to match updated design and API - add new tests and snapshots - preserve v1 for now, for comparisons and avoiding snapshot churn
booc0mtaco
force-pushed
the
aholloway/EDS-1136
branch
from
a41a821 to
55ee58d
Compare
|
closing in favor of #1889 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce new Button component, v2.0
Test Plan: