-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pin headlessui/react to 1.7.5 #1449
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
size-limit report
Path | Size |
---|---|
components | 123.95 KB (0%) |
styles | 3.1 KB (-6.69% 🔽) |
Codecov Report
@@ Coverage Diff @@
## next #1449 +/- ##
=======================================
Coverage 91.62% 91.62%
=======================================
Files 321 321
Lines 4619 4619
Branches 822 822
=======================================
Hits 4232 4232
Misses 357 357
Partials 30 30 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Resolves e2e test failures in Traject (see https://github.com/FB-PLP/traject/pull/13040). Issue starts in 1.7.6, possibly from tailwindlabs/headlessui#2093.
67849cd
to
41b11b4
Compare
@chanzuckerberg/edu-frontend-infra this is ready to go 🙏 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fast investigation
Thanks! |
@jinlee93 i think this was the version where we started seeing those weird warnings in EDS too... |
Pin headlessui/react to 1.7.5, to resolve E2E test failures in https://github.com/FB-PLP/traject/pull/13040.
Seeing
The
HTMLDocument.enforceFocus
makes me think this could be 2 different focus traps fighting for focus.This issue first shows up in headlessui/react 1.7.6.
The most suspicious changelog item is "Fix FocusTrap escape due to strange tabindex values" from tailwindlabs/headlessui#2093.
In any case, we should merge this PR to unblock updating EDS in Traject. A future effort can look at resolving unpinning.