feat(NumberIcon): remove sm size variant

chanzuckerberg · Mar 15, 2024 · 1a7b55f · 1a7b55f
1 parent 5d5c2d2
commit 1a7b55f
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 17 deletions.
diff --git a/src/components/NumberIcon/NumberIcon-v2.module.css b/src/components/NumberIcon/NumberIcon-v2.module.css
@@ -26,14 +26,6 @@
 /**
  * Size Variants.
  */
-.number-icon--size-sm {
-  /* Line height set to 1 here since this should only ever be on 1 line and it evens out padding in circle. */
-  line-height: 1;
-  height: 1rem;
-  width: 1rem;
-  min-width: 1rem;
-}
-
 .number-icon--size-md {
   height: 1.5rem;
   width: 1.5rem;

diff --git a/src/components/NumberIcon/NumberIcon-v2.stories.tsx b/src/components/NumberIcon/NumberIcon-v2.stories.tsx
@@ -28,7 +28,6 @@ export const Sizes: Story = {
   render: (args) => {
     return (
       <>
-        <NumberIcon number={1} size="sm" {...args} />
         <NumberIcon number={2} size="md" {...args} />
         <NumberIcon number={3} size="lg" {...args} />
       </>
@@ -100,16 +99,16 @@ export const DifferentNumbers: Story = {
  */
 export const NumberIconList: Story = {
   parameters: {
-    badges: ['intro-1.0', 'implementationExample'],
+    badges: ['intro-1.0', 'current-2.0', 'implementationExample'],
   },
   render: () => (
     <div className="flex flex-wrap gap-1">
-      <NumberIcon aria-label="Item 1" number={1} size="sm" />
-      <NumberIcon aria-label="Item 2" number={2} size="sm" />
-      <NumberIcon aria-label="Item 3" number={3} size="sm" />
-      <NumberIcon aria-label="Item 4" number={4} size="sm" />
-      <NumberIcon aria-label="Item 5" number={5} size="sm" />
-      <NumberIcon aria-label="Item 6" number={6} size="sm" />
+      <NumberIcon aria-label="Item 1" number={1} size="md" />
+      <NumberIcon aria-label="Item 2" number={2} size="md" />
+      <NumberIcon aria-label="Item 3" number={3} size="md" />
+      <NumberIcon aria-label="Item 4" number={4} size="md" />
+      <NumberIcon aria-label="Item 5" number={5} size="md" />
+      <NumberIcon aria-label="Item 6" number={6} size="md" />
     </div>
   ),
 };
diff --git a/src/components/NumberIcon/NumberIcon-v2.tsx b/src/components/NumberIcon/NumberIcon-v2.tsx
@@ -30,7 +30,7 @@ export interface Props {
    *
    * **Default is `"lg"`**.
    */
-  size?: Extract<Size, 'sm' | 'md' | 'lg'>;
+  size?: Extract<Size, 'md' | 'lg'>;
   /**
    * Indication of the status of the referenced item
    */