Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: mark outputs with sensitive attribute #546

Merged
merged 1 commit into from
Dec 22, 2023
Merged

Conversation

jakeyheath
Copy link
Contributor

@jakeyheath jakeyheath commented Dec 22, 2023

Summary

This PR adds the sensitive attribute to the outputs of this module which are required by newer versions of terraform. Specifically, master_password is a sensitive attribute and needs to marked as such otherwise terraform will throw:

╷
│ Error: Output refers to sensitive values
│ 
│   on outputs.tf line 24:
│   24: output "master_password" {
│ 
│ To reduce the risk of accidentally exporting sensitive data that was intended to be only internal, Terraform requires that any root module output containing sensitive data be explicitly marked as sensitive, to confirm your intent.
│ 
│ If you do intend to export this data, annotate the output value as sensitive by adding the following argument:
│     sensitive = true
╵

@jakeyheath jakeyheath requested a review from a team as a code owner December 22, 2023 21:12
@jakeyheath jakeyheath requested a review from fctczi December 22, 2023 21:12
@jakeyheath jakeyheath merged commit 732f4af into main Dec 22, 2023
102 of 104 checks passed
@jakeyheath jakeyheath deleted the jakeyheath-patch-1 branch December 22, 2023 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant