feat: CDI-2179 - Add databricks-workspace-e2 module #527
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kuannie1
reviewed
Oct 30, 2023
databricks-workspace-e2/variables.tf
Outdated
Comment on lines
54
to
58
| variable "audit_log_bucket_name" { | ||
| type = string | ||
| default = "czi-audit-logs" | ||
| description = "Name of bucket to write cluster logs to - also where the audit logs go, too" | ||
| } |
There was a problem hiding this comment.
remove our default & make it required
There was a problem hiding this comment.
Oops - thanks for catching
kuannie1
reviewed
Oct 30, 2023
databricks-workspace-e2/README.md
Outdated
There was a problem hiding this comment.
overall feedback: make this general. Don't include emails and stuff specific to CZI
kuannie1
approved these changes
Oct 30, 2023
|
Will redo with a clean commit |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Copy
databricks-workspace-e2from shared-infra to cztackTest Plan
Say unittests, or list out steps to verify changes.
References