Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] Fix Snowflake ALL modules on_future #284

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

edulop91
Copy link
Contributor

@edulop91 edulop91 commented Feb 3, 2021

Summary

Should fix Snowflake-Labs/terraform-provider-snowflake#318 (comment)

Note I'm bumping the test TF version to .13.6 so that we can point to snowflake provider registry and use it in tests.

Test Plan

New tests

References

@edulop91 edulop91 requested a review from ryanking February 3, 2021 14:52
snowflake-external-table-grant-all/module_test.go Outdated Show resolved Hide resolved
snowflake-stream-grant-all/module_test.go Outdated Show resolved Hide resolved
snowflake-warehouse-grant-all/module_test.go Outdated Show resolved Hide resolved
snowflake-integration-grant-all/module_test.go Outdated Show resolved Hide resolved
snowflake-sequence-grant-all/module_test.go Outdated Show resolved Hide resolved
snowflake-resource-monitor-grant-all/module_test.go Outdated Show resolved Hide resolved
snowflake-view-grant-all/module_test.go Outdated Show resolved Hide resolved
snowflake-file-format-grant-all/module_test.go Outdated Show resolved Hide resolved
snowflake-table-grant-all/module_test.go Outdated Show resolved Hide resolved
snowflake-procedure-grant-all/module_test.go Outdated Show resolved Hide resolved
Copy link
Contributor

@ryanking ryanking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm other than failing tests

@edulop91 edulop91 requested a review from a team as a code owner July 8, 2021 04:11
@edulop91 edulop91 requested a review from srm78 July 8, 2021 04:11
Copy link

@sfc-gh-pkommini sfc-gh-pkommini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

UPDATE: sorry wrong window.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants