Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add text-align: left style to Banner component #2577

Merged
merged 2 commits into from
Dec 30, 2024

Conversation

sungik-choi
Copy link
Contributor

@sungik-choi sungik-choi commented Dec 30, 2024

Self Checklist

  • I wrote a PR title in English and added an appropriate label to the PR.
  • I wrote the commit message in English and to follow the Conventional Commits specification.
  • I added the changeset about the changes that needed to be released. (or didn't have to)
  • I wrote or updated documentation related to the changes. (or didn't have to)
  • I wrote or updated tests related to the changes. (or didn't have to)
  • I tested the changes in various browsers. (or didn't have to)
    • Windows: Chrome, Edge, (Optional) Firefox
    • macOS: Chrome, Edge, Safari, (Optional) Firefox

Related Issue

Summary

Add text-align: left style to Banner component

Details

사용처 부모 요소의 텍스트 정렬 속성이 의도치 않게 오버라이드되지 않도록 기본 스타일 속성을 추가합니다.

Breaking change? (Yes/No)

No

References

@sungik-choi sungik-choi added the feat Issue or PR related to a new feature label Dec 30, 2024
@sungik-choi sungik-choi self-assigned this Dec 30, 2024
Copy link

changeset-bot bot commented Dec 30, 2024

🦋 Changeset detected

Latest commit: 1b4402b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@channel.io/bezier-react Patch
bezier-figma-plugin Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

channeltalk bot commented Dec 30, 2024

Copy link

codecov bot commented Dec 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.86%. Comparing base (ac2e9b1) to head (1b4402b).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2577   +/-   ##
=======================================
  Coverage   81.86%   81.86%           
=======================================
  Files         145      145           
  Lines        2889     2889           
  Branches      920      914    -6     
=======================================
  Hits         2365     2365           
  Misses        494      494           
  Partials       30       30           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

Chromatic Report

🚀 Congratulations! Your build was successful!

@sungik-choi sungik-choi merged commit d49849b into channel-io:main Dec 30, 2024
9 checks passed
@sungik-choi sungik-choi deleted the web-6132 branch December 30, 2024 07:41
sungik-choi pushed a commit that referenced this pull request Jan 6, 2025
This PR was opened by the [Changesets
release](https://github.com/changesets/action) GitHub action. When
you're ready to do a release, you can merge this and the packages will
be published to npm automatically. If you're not ready to do a release
yet, that's fine, whenever you add more changesets to main, this PR will
be updated.


# Releases
## @channel.io/[email protected]

### Patch Changes

- Add `text-align: left` style to `Banner` component.
([#2577](#2577)) by
@sungik-choi

## [email protected]

### Patch Changes

-   Updated dependencies
    -   @channel.io/[email protected]

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat Issue or PR related to a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants