Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate VSCode extension release to GH Action #2497

Merged
merged 7 commits into from
Nov 14, 2024
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
feat(bezier-vscode): integrate VSCode extension release to GH Action
yangwooseong committed Nov 14, 2024
commit 682094cd84cf274eb28ee2ba105dfa1dd4725b19
6 changes: 6 additions & 0 deletions .github/workflows/release.yml
Original file line number Diff line number Diff line change
@@ -39,3 +39,9 @@ jobs:
# https://github.com/changesets/action/issues/187
GITHUB_TOKEN: ${{ secrets.PERSONAL_ACCESS_TOKEN }}
NPM_TOKEN: ${{ secrets.NPM_TOKEN }}

- name: Release VSCode extension
continue-on-error: true
run: yarn publish-vscode
env:
VSCE_PAT: ${{ secrets.VSCE_PERSONAL_ACCESS_TOKEN }}
1 change: 1 addition & 0 deletions package.json
Original file line number Diff line number Diff line change
@@ -19,6 +19,7 @@
"update-snapshot": "yarn workspace @channel.io/bezier-react update-snapshot",
"changeset": "changeset",
"postinstall": "husky install",
"publish-vscode": "yarn workspace bezier-vscode publish --no-dependencies",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

자주 실행하는 커맨드라 alias 용도로 편리하게 사용하기 위한게 아니라면(이 기준이 좀 애매하긴 하지만) 각 패키지 종속적인 커맨드는 해당 패키지에 위치해있는게 좋을 거 같아요

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

그렇네요! bezier-vscode 패키지의 커맨드를 직접 실행하도록 변경했습니다

"knip": "knip --config knip.json --workspace packages/bezier-react --cache"
},
"devDependencies": {
3 changes: 2 additions & 1 deletion packages/bezier-vscode/package.json
Original file line number Diff line number Diff line change
@@ -59,7 +59,8 @@
"lint": "TIMING=1 eslint --cache .",
"typecheck": "tsc --noEmit",
"clean": "rm -rf dist",
"vscode:prepublish": "yarn build"
"vscode:prepublish": "yarn build",
"publish": "vsce publish"
},
"dependencies": {
"vscode-languageclient": "^9.0.1",