Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not trigger chromatic with changeset pr #2234

Conversation

yangwooseong
Copy link
Collaborator

Self Checklist

  • I wrote a PR title in English and added an appropriate label to the PR.
  • I wrote the commit message in English and to follow the Conventional Commits specification.
  • I added the changeset about the changes that needed to be released. (or didn't have to)
  • I wrote or updated documentation related to the changes. (or didn't have to)
  • I wrote or updated tests related to the changes. (or didn't have to)
  • I tested the changes in various browsers. (or didn't have to)
    • Windows: Chrome, Edge, (Optional) Firefox
    • macOS: Chrome, Edge, Safari, (Optional) Firefox

Related Issue

Summary

  • changeset PR에서 chromatic build가 실행되지 않도록 합니다.

Details

  • 생략

Breaking change? (Yes/No)

  • No

References

  • None

@yangwooseong yangwooseong added the ci Issue or PR related to continuous integration label May 22, 2024
@yangwooseong yangwooseong self-assigned this May 22, 2024
@yangwooseong yangwooseong requested a review from sungik-choi as a code owner May 22, 2024 01:30
Copy link

channeltalk bot commented May 22, 2024

Copy link

changeset-bot bot commented May 22, 2024

⚠️ No Changeset found

Latest commit: 26c3a7e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

codecov bot commented May 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.57%. Comparing base (6106129) to head (26c3a7e).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2234   +/-   ##
=======================================
  Coverage   84.57%   84.57%           
=======================================
  Files         134      134           
  Lines        2878     2878           
  Branches      860      873   +13     
=======================================
  Hits         2434     2434           
  Misses        439      439           
  Partials        5        5           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yangwooseong yangwooseong merged commit b9b77e1 into channel-io:main May 23, 2024
5 checks passed
@yangwooseong yangwooseong deleted the WEB-806/do-not-trigger-chromatic-in-changeset branch May 23, 2024 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Issue or PR related to continuous integration
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants