Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in IconProps jsdoc #2232

Merged
merged 2 commits into from
May 21, 2024

Conversation

yangwooseong
Copy link
Collaborator

Self Checklist

  • I wrote a PR title in English and added an appropriate label to the PR.
  • I wrote the commit message in English and to follow the Conventional Commits specification.
  • I added the changeset about the changes that needed to be released. (or didn't have to)
  • I wrote or updated documentation related to the changes. (or didn't have to)
  • I wrote or updated tests related to the changes. (or didn't have to)
  • I tested the changes in various browsers. (or didn't have to)
    • Windows: Chrome, Edge, (Optional) Firefox
    • macOS: Chrome, Edge, Safari, (Optional) Firefox

Related Issue

  • None

Summary

  • Icon 컴포넌트의 source 속성에 있는 jsdoc의 오타를 수정합니다.

Details

As-is To-be
image image

Breaking change? (Yes/No)

  • No

References

  • None

@yangwooseong yangwooseong added the fix PR related to bug fix label May 21, 2024
@yangwooseong yangwooseong self-assigned this May 21, 2024
@yangwooseong yangwooseong requested a review from sungik-choi as a code owner May 21, 2024 07:57
Copy link

changeset-bot bot commented May 21, 2024

🦋 Changeset detected

Latest commit: 62a35dc

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@channel.io/bezier-react Patch
bezier-figma-plugin Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

channeltalk bot commented May 21, 2024

Copy link
Contributor

Chromatic Report

🚀 Congratulations! Your build was successful!

@yangwooseong yangwooseong merged commit 6106129 into channel-io:main May 21, 2024
6 of 7 checks passed
@yangwooseong yangwooseong deleted the fix/fix-typo-in-jsdoc branch May 21, 2024 08:00
yangwooseong pushed a commit that referenced this pull request May 29, 2024
This PR was opened by the [Changesets
release](https://github.com/changesets/action) GitHub action. When
you're ready to do a release, you can merge this and the packages will
be published to npm automatically. If you're not ready to do a release
yet, that's fine, whenever you add more changesets to main, this PR will
be updated.


# Releases
## @channel.io/[email protected]

### Patch Changes

- Change `position` property of `ToastContainer` to `fixed`
([#2245](#2245)) by
@yangwooseong

- Fix typo in `IconProps` jsdoc
([#2232](#2232)) by
@yangwooseong

- - Fix ReactJS console warnings.
([#2238](#2238)) by
@nabi-chan
- Introduce `useIsomorphicLayoutEffect` hook to use `useLayoutEffect` in
SSR environment.

- Add `AlphaSpinner` component
([#2237](#2237)) by
@yangwooseong

## [email protected]

### Patch Changes

-   Updated dependencies
    -   @channel.io/[email protected]

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix PR related to bug fix
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants