Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ArrowRightUp icon broken bug by upgrading svgo library #1896

Merged
merged 3 commits into from
Jan 10, 2024

Conversation

yangwooseong
Copy link
Collaborator

@yangwooseong yangwooseong commented Jan 10, 2024

Self Checklist

  • I wrote a PR title in English and added an appropriate label to the PR.
  • I wrote the commit message in English and to follow the Conventional Commits specification.
  • I added the changeset about the changes that needed to be released. (or didn't have to)
  • I wrote or updated documentation related to the changes. (or didn't have to)
  • I wrote or updated tests related to the changes. (or didn't have to)
  • I tested the changes in various browsers. (or didn't have to)
    • Windows: Chrome, Edge, (Optional) Firefox
    • macOS: Chrome, Edge, Safari, (Optional) Firefox

Related Issue

  • None

Summary

  • ArrowRightUp icon 이 깨지는 버그를 수정합니다. (target branch: main)

image

Details

  • svgo 3.0.3 에서 빌드했을 때는 안깨지다가 3.0.4에서 빌드하면 깨지는 것으로 보아 svgo 라이브러리의 문제라고 추정됩니다.
  • 최신 버전(3.2.0)에서 빌드하면 재현이 안되는 것을 확인했기 때문에 최신 버전으로 업그레이드 합니다. 빌드 결과는 커멘트로 달리는 스토리북 프리뷰를 참고해주세요.
  • 시각 회귀 테스트가 잘 동작했다면 사전에 방지할 수 있었을 것으로 보입니다 (Enhance Chromatic UI snapshot test #1000)

Breaking change? (Yes/No)

  • No

References

@yangwooseong yangwooseong added bug Issues related to anything that isn't working dependencies Pull requests that update a dependency file (Dependabot) bezier-icons Issue or PR related to bezier-icons labels Jan 10, 2024
@yangwooseong yangwooseong self-assigned this Jan 10, 2024
Copy link

changeset-bot bot commented Jan 10, 2024

🦋 Changeset detected

Latest commit: 0e57328

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@channel.io/bezier-icons Minor
bezier-figma-plugin Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

Chromatic Report

🚀 Congratulations! Your build was successful!

Copy link

codecov bot commented Jan 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b6b16e9) 87.81% compared to head (0e57328) 87.81%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1896   +/-   ##
=======================================
  Coverage   87.81%   87.81%           
=======================================
  Files         282      282           
  Lines        3963     3963           
  Branches      826      826           
=======================================
  Hits         3480     3480           
  Misses        411      411           
  Partials       72       72           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@sungik-choi sungik-choi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@yangwooseong yangwooseong merged commit 1093c94 into channel-io:main Jan 10, 2024
11 checks passed
@yangwooseong yangwooseong deleted the deps/bump-svgo-to-3.2.0 branch January 10, 2024 08:45
sungik-choi pushed a commit that referenced this pull request Jan 10, 2024
This PR was opened by the [Changesets
release](https://github.com/changesets/action) GitHub action. When
you're ready to do a release, you can merge this and the packages will
be published to npm automatically. If you're not ready to do a release
yet, that's fine, whenever you add more changesets to main, this PR will
be updated.


# Releases
## @channel.io/[email protected]

### Minor Changes

- Fix `ArrowRightUp` icon broken bug
([#1896](#1896)) by
@yangwooseong

## [email protected]

### Patch Changes

-   Updated dependencies
    -   @channel.io/[email protected]
    -   @channel.io/[email protected]

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bezier-icons Issue or PR related to bezier-icons bug Issues related to anything that isn't working dependencies Pull requests that update a dependency file (Dependabot)
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants