Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(foundation): update theme #1506

Merged
merged 4 commits into from
Jul 18, 2023

Conversation

sungik-choi
Copy link
Contributor

@sungik-choi sungik-choi commented Jul 18, 2023

Self Checklist

  • I wrote a PR title in English.
  • I added an appropriate label to the PR.
  • I wrote a commit message in English.
  • I wrote a commit message according to the Conventional Commits specification.
  • I added the appropriate changeset for the changes.
  • [Component] I wrote a unit test about the implementation.
  • [Component] I wrote a storybook document about the implementation.
  • [Component] I tested the implementation in various browsers.
    • Windows: Chrome, Edge, (Optional) Firefox
    • macOS: Chrome, Edge, Safari, (Optional) Firefox
  • [New Component] I added my username to the correct directory in the CODEOWNERS file.

Related Issue

없음

Summary

  1. 시멘틱에 txt-black-pure 추가 (black ↔ white)
  2. 팔레트에 grey800_90 추가 후 bg-lounge 다크테마 색상을 해당 컬러로 변경

Details

생략

Breaking change or not (Yes/No)

No

References

@sungik-choi sungik-choi added feat:foundation Issue of PR related to a new foundation design update Issue or PR that Up-to-date specifications for design system updates labels Jul 18, 2023
@sungik-choi sungik-choi self-assigned this Jul 18, 2023
@changeset-bot
Copy link

changeset-bot bot commented Jul 18, 2023

🦋 Changeset detected

Latest commit: 62cdc0d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@channel.io/bezier-react Minor
bezier-figma-plugin Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@sungik-choi sungik-choi requested a review from dinohan July 18, 2023 06:15
@codecov
Copy link

codecov bot commented Jul 18, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (e25ef98) 87.31% compared to head (62cdc0d) 87.31%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1506   +/-   ##
=======================================
  Coverage   87.31%   87.31%           
=======================================
  Files         280      280           
  Lines        3848     3848           
  Branches      805      805           
=======================================
  Hits         3360     3360           
  Misses        415      415           
  Partials       73       73           
Impacted Files Coverage Δ
...ezier-react/src/foundation/Colors/Palette/index.ts 100.00% <ø> (ø)
...t/src/foundation/Colors/Theme/presets/DarkTheme.ts 100.00% <ø> (ø)
.../src/foundation/Colors/Theme/presets/LightTheme.ts 100.00% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 18, 2023

Chromatic Report

🚀 Congratulations! Your build was successful!

@sungik-choi sungik-choi merged commit ffcb34d into channel-io:main Jul 18, 2023
@sungik-choi sungik-choi deleted the feat/update-theme branch July 18, 2023 06:23
@dinohan
Copy link
Member

dinohan commented Jul 18, 2023

빛보다 빠른 머지

sungik-choi added a commit to sungik-choi/bezier-react that referenced this pull request Jul 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design update Issue or PR that Up-to-date specifications for design system updates feat:foundation Issue of PR related to a new foundation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants