Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create components using new foundation #2148

Open
10 of 42 tasks
Tracked by #2074
yangwooseong opened this issue Apr 9, 2024 · 6 comments
Open
10 of 42 tasks
Tracked by #2074

Create components using new foundation #2148

yangwooseong opened this issue Apr 9, 2024 · 6 comments
Assignees
@yangwooseong @babycroc @sungik-choi
Labels
epic Issue consisting of multiple issues of the same purpose

Comments

@yangwooseong
Copy link
Collaborator

yangwooseong commented Apr 9, 2024 •
edited by sungik-choi
Loading

Summary

  • 리디자인된 디자인 토큰을 사용해서 컴포넌트를 다시 구현합니다.

Description

  • 먼저 새로운 컴포넌트 구현에 관한 RFC 문서 이슈를 작성해주세요. 예시는 다른 이슈들을 참고해주세요.
  • 문서 작성이 완료되면 메인테이너(@sungik-choi, @yangwooseong)에게 채널톡 팀챗, 이슈 코멘트를 통해 리뷰를 요청해주세요.
  • 문서 리뷰가 완료되면 논의된 스펙을 바탕으로 구현 작업을 시작합니다.
  • 기존의 컴포넌트는 그대로 두고 새로운 파일을 만들어서 작업합니다. Breaking change를 만들지 마세요.
  • 컴포넌트 이름에 Alpha prefix 를 붙이고 버저닝은 항상 patch 버전 업으로 합니다. (위키 참고)

Tasks
Preview Give feedback
  1. Avatar #2151
    feat:component
    yangwooseong
  2. AvatarGroup #2163
    feat:component
    yangwooseong
  6. Button #2178
    feat:component
    yangwooseong
  7. CheckBox #2235
    feat:component
    yangwooseong
  12. Icon #2570
    feat:component
    sungik-choi
  13. Icon Button #2199
    feat:component
    yangwooseong
  16. Floating Icon Button #2180
    feat:component
    yangwooseong
  17. Floating Button #2179
    feat:component
    yangwooseong
  28. Spinner #2236
    feat:component
    yangwooseong
  34. Tag #2463
    feat:component
    yangwooseong
  41. ToggleButton #2271
    feat:component
    yangwooseong
  42. ToggleButtonGroup #2277
    feat:component
    yangwooseong

References
@yangwooseong yangwooseong added the epic Issue consisting of multiple issues of the same purpose label Apr 9, 2024
@github-project-automation github-project-automation bot moved this to 📌 Backlog in Bezier React Apr 9, 2024
@yangwooseong yangwooseong mentioned this issue Apr 9, 2024
Open
@sungik-choi
Copy link
Contributor

https://github.com/orgs/channel-io/projects/9/views/9 에 start, end date 설정도 해주시면 더 좋을 거 같습니다!

@yangwooseong
Copy link
Collaborator Author

https://github.com/orgs/channel-io/projects/9/views/9 에 start, end date 설정도 해주시면 더 좋을 거 같습니다!

캘린더에 일정이 없는 컴포넌트들 (Checkbox 부터) 의 start, end date 를 설정하면 좋을 것 같다는 의미인가요? 아니면 이 이슈를 캘린더에 추가하면 좋겠다는 의미인가요?

@sungik-choi
Copy link
Contributor

이 이슈 자체를 말씀드린거였어요.
Tasks 내부의 각 컴포넌트별 태스크들도 개별 이슈로 만들어서 관리하면 더 좋을 거 같습니다(우측 ... -> Convert to Issue). 프로젝트랑 연동할 수 있어서요!

@yangwooseong
Copy link
Collaborator Author

프로젝트에서 이미 만든 티켓을 이슈로 만들고 tasks 에 반영했습니다!

@yangwooseong yangwooseong self-assigned this Apr 12, 2024
@channel-io channel-io deleted a comment from channeltalk-exp bot Apr 12, 2024
@sungik-choi sungik-choi removed the epic Issue consisting of multiple issues of the same purpose label Apr 12, 2024
@quino0627 quino0627 added U0_NONE labels Apr 16, 2024 — with Linear
@yangwooseong yangwooseong added epic Issue consisting of multiple issues of the same purpose and removed U0_NONE labels Apr 16, 2024
@yangwooseong yangwooseong moved this from 📌 Backlog to 🏃‍♀️ In progress in Bezier React Jun 13, 2024
@sungik-choi
Copy link
Contributor

이슈 설명에 작업 방식 업데이트 했습니다 Fyi. @yangwooseong

@channeltalk ChannelTalk
Copy link

channeltalk bot commented Nov 15, 2024

https://desk.channel.io/#/channels/1/team_chats/groups/1237/673702e9bdb7e4b6681c

@sungik-choi sungik-choi mentioned this issue Dec 16, 2024
Merged
6 tasks
sungik-choi added a commit that referenced this issue Dec 17, 2024
@sungik-choi
Add alpha design token types (#2564)
bc4319e 
<!--
  How to write a good PR title:
- Follow [the Conventional Commits
specification](https://www.conventionalcommits.org/en/v1.0.0/).
  - Give as much context as necessary and as little as possible
  - Prefix it with [WIP] while it’s a work in progress
-->

## Self Checklist

- [x] I wrote a PR title in **English** and added an appropriate
**label** to the PR.
- [x] I wrote the commit message in **English** and to follow [**the
Conventional Commits
specification**](https://www.conventionalcommits.org/en/v1.0.0/).
- [x] I [added the
**changeset**](https://github.com/changesets/changesets/blob/main/docs/adding-a-changeset.md)
about the changes that needed to be released. (or didn't have to)
- [x] I wrote or updated **documentation** related to the changes. (or
didn't have to)
- [x] I wrote or updated **tests** related to the changes. (or didn't
have to)
- [x] I tested the changes in various browsers. (or didn't have to)
  - Windows: Chrome, Edge, (Optional) Firefox
  - macOS: Chrome, Edge, Safari, (Optional) Firefox

## Related Issue

<!-- Please link to issue if one exists -->

- #2148 

## Summary

<!-- Please brief explanation of the changes made -->

- 알파 버전의 디자인 토큰 타입을 추가합니다
- 알파 버전의 디자인 토큰 프로바이더와 관련 훅, 토큰 객체를 export 합니다.

## Details

<!-- Please elaborate description of the changes -->

- `alphaTokens` 로 토큰 객체에, `AlphaTokens` 네임스페이스로 토큰 타입에 접근할 수 있도록 합니다.
- `useAlphaTokens` 훅으로 자바스크립트에서 현재 테마명에 맞는 알파 버전 디자인 토큰에 접근할 수 있습니다.
- `ThemeProvider` 도 `AlphaThemeProvider` 를 별도로 두어야하나 고민했지만, 이미 알파 디자인
토큰이 스타일 시트에 말려들어가있어서 `ThemeProvider` 하나만(= `AppProvider` 하나만) 사용하더라도
`useAlphaTokens` 훅을 사용할 수 있도록 해도 괜찮겠다고 생각했습니다.
- 현재 토큰 객체 구조상, 타이핑할 때 Functional Semantic 토큰을 묶어서 지칭할 수 있는 용어가 필요한데 현재
디자인 시스템에는 따로 정의가 없습니다. 임시로 학습 비용이 최대한 적은 방향으로, 기존과 동일하게 SemanticToken
이라고 칭했습니다.

### Breaking change? (Yes/No)

<!-- If Yes, please describe the impact and migration path for users -->

No

## References

<!-- Please list any other resources or points the reviewer should be
aware of -->

없음
@sungik-choi sungik-choi pinned this issue Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yangwooseong yangwooseong

@babycroc babycroc

@sungik-choi sungik-choi

Labels
epic Issue consisting of multiple issues of the same purpose
Projects
No open projects
Bezier React
Status: 🏃‍♀️ In progress
Milestone
No milestone
Development

No branches or pull requests
4 participants
@yangwooseong @babycroc @quino0627 @sungik-choi