Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix(form-label/helper-text): fix merging of classname not working pro…
…perly when inside a `FormControl` (#2156) <!-- How to write a good PR title: - Follow [the Conventional Commits specification](https://www.conventionalcommits.org/en/v1.0.0/). - Give as much context as necessary and as little as possible - Prefix it with [WIP] while it’s a work in progress --> ## Self Checklist - [x] I wrote a PR title in **English** and added an appropriate **label** to the PR. - [x] I wrote the commit message in **English** and to follow [**the Conventional Commits specification**](https://www.conventionalcommits.org/en/v1.0.0/). - [x] I [added the **changeset**](https://github.com/changesets/changesets/blob/main/docs/adding-a-changeset.md) about the changes that needed to be released. (or didn't have to) - [x] I wrote or updated **documentation** related to the changes. (or didn't have to) - [x] I wrote or updated **tests** related to the changes. (or didn't have to) - [x] I tested the changes in various browsers. (or didn't have to) - Windows: Chrome, Edge, (Optional) Firefox - macOS: Chrome, Edge, Safari, (Optional) Firefox ## Summary <!-- Please brief explanation of the changes made --> FormControl 내부에 위치한 FormLabel, FormHelperText(ErrorMessage)에 className 오버라이드가 잘 적용되지 않는 문제를 수정합니다. ## Details <!-- Please elaborate description of the changes --> 베지어 마이그레이션 과정에서 FormControl이 FormLabel, FormHelperText에게 래퍼 스타일을 전달하는 과정이 변경되었습니다. 변경 과정에서 `get***Props` 함수가 반환하는 `className` 과 인자로 받는 `className` 의 속성명이 서로 겹치게 되었는데, 이 때 두 className이 모두 적용되는 게 아니라 인자로 받는 `className` 이 우선순위를 가지고 적용되면서 FormControl이 전달하는 래퍼 스타일이 무시되는 버그가 있었습니다. 이를 수정합니다. ### Breaking change? (Yes/No) No <!-- If Yes, please describe the impact and migration path for users --> ## References <!-- Please list any other resources or points the reviewer should be aware of --> - [Channel Desk](https://desk.channel.io/root/threads/groups/Bug-10/6617adea666db15cf58f/6617adea666db15cf58f)
- Loading branch information