Skip to content

Commit

Permalink
Set autoAcceptChanges true in chromatic (#2222)
Browse files Browse the repository at this point in the history
<!--
  How to write a good PR title:
- Follow [the Conventional Commits
specification](https://www.conventionalcommits.org/en/v1.0.0/).
  - Give as much context as necessary and as little as possible
  - Prefix it with [WIP] while it’s a work in progress
-->

## Self Checklist

- [x] I wrote a PR title in **English** and added an appropriate
**label** to the PR.
- [x] I wrote the commit message in **English** and to follow [**the
Conventional Commits
specification**](https://www.conventionalcommits.org/en/v1.0.0/).
- [x] I [added the
**changeset**](https://github.com/changesets/changesets/blob/main/docs/adding-a-changeset.md)
about the changes that needed to be released. (or didn't have to)
- [x] I wrote or updated **documentation** related to the changes. (or
didn't have to)
- [x] I wrote or updated **tests** related to the changes. (or didn't
have to)
- [x] I tested the changes in various browsers. (or didn't have to)
  - Windows: Chrome, Edge, (Optional) Firefox
  - macOS: Chrome, Edge, Safari, (Optional) Firefox

## Related Issue

<!-- Please link to issue if one exists -->

<!-- Fixes #0000 -->

- None

## Summary

<!-- Please brief explanation of the changes made -->

- autoAcceptChanges 옵션을 true 로 둬서 chromatic UI test 에 의해 checks가 pending
으로 되는 것을 막습니다.
- 테스트 pr: yangwooseong#150

## Details

<!-- Please elaborate description of the changes -->

- autoAcceptChanges: true 로 changes를 항상 승인해서 checks 가 통과되게 되지만 checks 에서
visual test나 UI review 가 안보이게 되는 단점은 있습니다. 다만 커멘트로 나오는 chromatic build
링크를 타고 들어가면 승인된 visual test 를 확인할 수 있어서 괜찮을 것 같기도 합니다.

<img width="929" alt="image"
src="https://github.com/channel-io/bezier-react/assets/28595102/81e7656c-4f81-4d51-b26d-49e782101cb5">


### Breaking change? (Yes/No)

<!-- If Yes, please describe the impact and migration path for users -->

- No

## References

<!-- Please list any other resources or points the reviewer should be
aware of -->

- https://www.chromatic.com/docs/cli/#configuration-options
  • Loading branch information
yangwooseong authored May 16, 2024
1 parent de53903 commit 45d2e41
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions .github/workflows/chromatic.yml
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,7 @@ jobs:
with:
workingDir: packages/bezier-react
exitZeroOnChanges: true
autoAcceptChanges: true
skip: dependabot/**
projectToken: 06157a6fbe6f

Expand Down

0 comments on commit 45d2e41

Please sign in to comment.