Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BSBUtton Input Submit changed to Button Submit #209

Merged
merged 1 commit into from
Sep 27, 2019

Conversation

EmaX093
Copy link
Contributor

@EmaX093 EmaX093 commented Sep 27, 2019

BSButton type Submit is rendered as an input. Is this intended?

@jbomhold3
Copy link
Collaborator

I was intended in the original design. However, I think it's confusing to expect a button and get an input. We could always add submit type to the input. Then people would expect to set the value of the label. The way it is now the label does not show up on all browsers. @chanan thoughts?

@chanan
Copy link
Owner

chanan commented Sep 27, 2019

Isn't an input because if you put it on a form as input type="submit" it will automatically bind the enter key to form submit, while button won't?

Looking at https://getbootstrap.com/docs/4.3/components/forms/ I see it should be:

<button type="submit" class="btn btn-primary">Submit</button>

We should change to match that

@jbomhold3 jbomhold3 merged commit b3db4a6 into chanan:master Sep 27, 2019
@jbomhold3 jbomhold3 added this to the 1.0.101 milestone Sep 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants