take care of hermes javascript engine #78
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Qix-
requested changes
Nov 4, 2021
| @@ -129,12 +129,12 @@ function assembleStyles() { | |||
| }, | |||
| hexToRgb: { | |||
| value: hex => { | |||
| const matches = /(?<colorString>[a-f\d]{6}|[a-f\d]{3})/i.exec(hex.toString(16)); | |||
| const matches = /([a-f\d]{6}|[a-f\d]{3})/i.exec(hex.toString(16)); | |||
There was a problem hiding this comment.
Suggested change
| const matches = /([a-f\d]{6}|[a-f\d]{3})/i.exec(hex.toString(16)); | |
| const matches = /[a-f\d]{6}|[a-f\d]{3}/i.exec(hex.toString(16)); |
|
While this is a seemingly simple change, it's a slippery slope. Hermes only supports ES6, so this issue will be hit again in the future. |
It will be ok to me if you add me as a maintainer of this little library. :) |
|
for those suffering such little problem, now I recommend https://www.npmjs.com/package/patch-package. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is sad that hermes do not support regex named group.
https://github.com/facebook/hermes/blob/main/doc/RegExp.md
same issue others encountered as me :)
facebook/hermes#89
because this library is so foundamental and small, it will be a pleasure if this library can do the favor.
:)