Associative Reduce #129
Merged
Associative Reduce #129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello Sasha! I'm very happy to hear from you! I've noticed that you are still making good use of chalk in your side projects. I feel a bit guilty that I couldn't keep up with the active development of the library, but I still hope to find some free time to start addressing some of the issues. Thanks for the PR! Yes, efficiency is a sore point of the current implementation, so using the log(N) variant of |
|
Honestly it mostly works well for my use cases! Speed is mostly not a problem. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey @danoneata! Long time!
I've been using chalk for a new project and I realized that functools is really dumb about reductions. It doesn't make any assumption about the associativity of the operator which means we are recursing to an O(N) depth with the functional style not O(log(N)). This change fixes the problem with no change to the underlying code.