Passing correct module specifier when setting a parent #4548
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
fixes #3638 |
|
@boingoing please have a look. |
|
@dotnet-bot please test OSX static_osx_osx_debug |
|
This should be a quick review, anyone? |
boingoing
approved these changes
Jan 16, 2018
|
AsmJs/params.js is timing out, is this known @MikeHolman ? I am going to retry it one more time. |
|
@dotnet-bot please test OSX static_osx_osx_debug |
As multiple specifier can lead to the same module record.
chakrabot
pushed a commit
that referenced
this pull request
Jan 17, 2018
chakrabot
pushed a commit
that referenced
this pull request
Jan 17, 2018
…n setting a parent Merge pull request #4548 from akroshg:setparent
chakrabot
pushed a commit
that referenced
this pull request
Jan 17, 2018
…specifier when setting a parent Merge pull request #4548 from akroshg:setparent
chakrabot
pushed a commit
that referenced
this pull request
Jan 30, 2018
…ition. Merge pull request #4585 from rhuanjl:setparent Follow up to issue: #3638 The issue was already fixed by removing the unnecessary assert: #4548 But - it highlighted another small issue. The setParent call in JsrtCore is useless - it results in several operations all of which have no useful end result. (No test case included as this doesn't fix a bug it just removes useless code)
chakrabot
pushed a commit
to nodejs/node-chakracore
that referenced
this pull request
Jan 31, 2018
[MERGE #4585 @rhuanjl] Remove useless setParent call and related condition. Merge pull request #4585 from rhuanjl:setparent Follow up to issue: chakra-core/ChakraCore#3638 The issue was already fixed by removing the unnecessary assert: chakra-core/ChakraCore#4548 But - it highlighted another small issue. The setParent call in JsrtCore is useless - it results in several operations all of which have no useful end result. (No test case included as this doesn't fix a bug it just removes useless code) Reviewed-By: chakrabot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.