-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release/2.0 pre to Master #2170
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Do not use private heap on xplat. Currently with our static linking in node-chakracore our overridden new/delete operators are picked up by node itself. Use of the private heap leads to instability on shutdown due to the chance that HeapAllocator::Instance is disposed before other allocations. Using alloc and free instead circumvents this problem.
Merge pull request #2088 from ianwjhalliday:release/2.0-pre Do not use private heap on xplat. Currently with our static linking in node-chakracore our overridden new/delete operators are picked up by node itself. Use of the private heap leads to instability on shutdown due to the chance that HeapAllocator::Instance is disposed before other allocations. Using alloc and free instead circumvents this problem.
ChakraCore no longer depends on libunwind on cross platform
Merge pull request #2094 from mrkmarron:TTSnapSerialize - Use text serialization for debug & release builds.
Merge pull request #2086 from obastemur:wind_free ChakraCore no longer depends on libunwind on cross platform
…fy CI configuration.
Previous regex was a little too restrictive and caused branches with names like release/2.0-pre to not have linux or osx daily builds. Relax the matching so those branches can get linux and osx build tasks.
…lease branches Merge pull request #2156 from boingoing:release/2.0-pre Previous regex was a little too restrictive and caused branches with names like release/2.0-pre to not have linux or osx daily builds. Relax the matching so those branches can get linux and osx build tasks.
chakrabot
pushed a commit
that referenced
this pull request
Dec 8, 2016
Merge pull request #2170 from release/2.0-pre /cc @digitalinfinity
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/cc @digitalinfinity