Cmake Fixes #2084
Closed
Cmake Fixes #2084
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ables. This is the initial commit in changes that are meant to avoid variable pollution by ChakraCore in CMake.
This script will generate and launch eclipse projects for ChakraCore. The arguments for this script are similar to the build.sh script.
This causes cmake to properly handle specifying building ChakraCore as a static library or shared library using Options.
Use CC_ENABLE_JIT configuration option to enable and disable JIT support with CMakeList.
This copies the headers that ChakraCore uses to the cmake build directory.
This Option will Automatically configure CPU options for CMake.
When this option is set to true, cmake will find pkg_config and use the recommended method for detecting the Internationalization libraries.
The appropriate headers where not being copied when including ChakraCore using the add_subdirectory command.
This should help in reducing linking errors for projects wishing to link to ChakraCore library.
These functions are the basis for the new ChakraCore library initialization and finalization steps.
This fixes shared library builds of ChakraCore. This takes place in two steps... Step 1: Initialize Process/Runtime using JsInitializeRuntime. Step 2: Remember to Finalize runtime by calling JsFinalizeRuntime after all other contexts are destroyed.
This is a merge of all changes from Upstream ChakraCore.
Add the two newly created functions to the Jsrt common exports.
|
Hi @kphillisjr, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution! TTYL, MSBOT; |
This should fix the windows compile by defining the missing elements.
This fixes some whitespace errors that appeared in the changes I added.
This is just minor whitespace error fixes.
The location of Static builds has changed, this fixes the detection of static library builds.
|
@kphillisjr couple of pointers;
Thanks |
|
@obastemur, I'll rework the patches and push a new set of commits. Some of the commits are no longer needed anymore. |
|
I reworked the automatic configuration to avoid directly modifying CMakeListst.txt. The new code is found in pull #2111. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This includes many of the changes/fixes outlined in bug report #1616. This also includes a solution to bug report #1811.
NOTE 1: many of the changes in this pull request need testing on windows.
NOTE 2: This should include fixes to help with running Static Library on windows, Just remember to call the new Jsrt calls before running any other jsrt function.