Fix index state with UPDATE queries #368
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes how UPDATE queries on indexed tables would cause some indexes to be in an incorrect state.
This was caused by the "trash bin" mechanism implemented in both bolt and memory engines, where nodes would get marked as deleted without modifying the btree and then actually removed when the transaction is committed.
The error occurred when a key was marked for deletion and then overwritten (which happens a lot when we run UPDATE on indexed fields that are not modified), the cleanup mechanism would delete them even when it's not supposed to.
This PR also fixes a race condition occurring in the memory engine.
Fixes #355