Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix driver.Sql with Stream.Operator finder. #352

Merged
merged 2 commits into from
Feb 25, 2021
Merged

Fix driver.Sql with Stream.Operator finder. #352

merged 2 commits into from
Feb 25, 2021

Conversation

tzzed
Copy link
Contributor

@tzzed tzzed commented Feb 24, 2021

This fixes #338.

asdine
asdine reviewed Feb 25, 2021
View reviewed changes
sql/driver/driver.go Outdated
@@ -311,7 +316,7 @@ func (s stmt) Close() error {
return nil
}

var errStop = errors.New("stop")
var ErrStop = errors.New("stop")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason for unexporting this?

asdine
asdine approved these changes Feb 25, 2021
View reviewed changes
Copy link
Collaborator

@asdine asdine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @tzzed !

@asdine asdine merged commit 5baedd6 into chaisql:main Feb 25, 2021
@asdine asdine modified the milestone: v0.11.0 Mar 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asdine asdine asdine approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

database/sql ORDER BY error
2 participants
@tzzed @asdine