-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added go-fuzz for parser #253
Conversation
Codecov Report
@@ Coverage Diff @@
## master #253 +/- ##
=======================================
Coverage 61.35% 61.35%
=======================================
Files 68 68
Lines 6345 6345
=======================================
Hits 3893 3893
Misses 1936 1936
Partials 516 516
Continue to review full report at Codecov.
|
Could we run the fuzzer on a Github Action when a branch is merged on master for example? |
Yes, we can do that. I think it’s better to run a scheduled nightly fuzz test. I’ll write a workflow that stores corpus in cache, but we’d probably need a separate repo or some kind of file storage for |
@tie Is this something that must be generated once and stored somewhere? If so, how about storing it in the Genji repo directly? |
For each |
@tie I have created a repo for storing the corpus data: https://github.com/genjidb/go-fuzz-corpus |
@tie Is it ready for review? |
@asdine yes! There would be another PR to Note that the (1.15.x, windows, genji/engine/badgerengine) combo fails with |
4b4a54e
to
063eae0
Compare
I’ve removed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @tie ! That's great job! Let's iterate on this for tinygo and race on subsequent PRs 👍🏼
Neat, it’s working. Found another bug too! |
It’d be nice to integrate continuous fuzzing too, but I’m not aware of any easy to set up (and free) services.
See also #252