Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC 001: Cancelable operations and use of Context #249

Merged
merged 5 commits into from
Oct 25, 2020
Merged

RFC 001: Cancelable operations and use of Context #249

merged 5 commits into from
Oct 25, 2020

Conversation

asdine
Copy link
Collaborator

@asdine asdine commented Oct 10, 2020

This PR adds an RFC about how we should use Context in Genji.

It is opened for comments and suggestions.

@codecov-io
Copy link

codecov-io commented Oct 10, 2020

Codecov Report

Merging #249 into master will decrease coverage by 0.82%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #249      +/-   ##
==========================================
- Coverage   61.61%   60.78%   -0.83%     
==========================================
  Files          67       68       +1     
  Lines        6273     6579     +306     
==========================================
+ Hits         3865     3999     +134     
- Misses       1895     2060     +165     
- Partials      513      520       +7     
Impacted Files Coverage Δ
engine/memoryengine/store.go 91.96% <0.00%> (-1.79%) ⬇️
sql/parser/options.go 100.00% <0.00%> (ø)
sql/query/expr/function.go 6.55% <0.00%> (+0.82%) ⬆️
sql/parser/expr.go 80.95% <0.00%> (+2.67%) ⬆️
sql/parser/parser.go 87.68% <0.00%> (+4.70%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d7ed9d8...faed8c6. Read the comment docs.

rfcs/001_context.md Outdated Show resolved Hide resolved
@tie
Copy link
Contributor

tie commented Oct 11, 2020

I think parser.ParseQuery shouldn’t accept context (it does so now). Parsing statements shouldn’t be an expensive operation.

@asdine
Copy link
Collaborator Author

asdine commented Oct 17, 2020

@tie @yaziine Do you see any blocker for this RFC?

@asdine asdine requested a review from yaziine October 17, 2020 12:07
Copy link
Collaborator

@yaziine yaziine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything seems fine to me. 👍

Copy link
Contributor

@tie tie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One last suggestion, everything else looks great!

rfcs/001_context.md Show resolved Hide resolved
rfcs/001_context.md Show resolved Hide resolved
@asdine asdine merged commit c88e7de into master Oct 25, 2020
@asdine asdine deleted the rfc/001 branch October 25, 2020 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants