-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RFC 001: Cancelable operations and use of Context #249
Conversation
Codecov Report
@@ Coverage Diff @@
## master #249 +/- ##
==========================================
- Coverage 61.61% 60.78% -0.83%
==========================================
Files 67 68 +1
Lines 6273 6579 +306
==========================================
+ Hits 3865 3999 +134
- Misses 1895 2060 +165
- Partials 513 520 +7
Continue to review full report at Codecov.
|
I think |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything seems fine to me. 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One last suggestion, everything else looks great!
Co-authored-by: Ivan Trubach <[email protected]>
This PR adds an RFC about how we should use
Context
in Genji.It is opened for comments and suggestions.