Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Encode documents using MessagePack #117

Merged
merged 6 commits into from
Jul 18, 2020
Merged

Encode documents using MessagePack #117

merged 6 commits into from
Jul 18, 2020

Conversation

asdine
Copy link
Collaborator

@asdine asdine commented Jul 12, 2020

This PR replaces the current custom encoding system with MessagePack. It introduces a new msgpack package that takes care of encoding documents.

@asdine asdine requested a review from yaziine July 15, 2020 21:06
yaziine
yaziine reviewed Jul 16, 2020
View reviewed changes
Copy link
Collaborator

@yaziine yaziine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a very nice work 👏

I added some questions/remarks/suggestions.

I think that adding some benchmarks for arrays worth it, what do you think?

document/encoding/msgpack/codec.go Show resolved Hide resolved
document/encoding/msgpack/codec.go Show resolved Hide resolved
document/encoding/msgpack/codec.go Show resolved Hide resolved
document/encoding/msgpack/codec.go Show resolved Hide resolved
document/encoding/msgpack/codec.go Show resolved Hide resolved
document/encoding/msgpack/encoding.go Outdated Show resolved Hide resolved
document/encoding/msgpack/encoding.go Outdated Show resolved Hide resolved
document/encoding/msgpack/encoding_test.go Show resolved Hide resolved
document/encoding/msgpack/encoding_test.go Show resolved Hide resolved
document/encoding/msgpack/encoding_test.go Outdated Show resolved Hide resolved
@asdine asdine merged commit 58ffab2 into master Jul 18, 2020
@asdine asdine deleted the messagepack branch July 18, 2020 16:55
@asdine asdine modified the milestones: v0.8.0, v0.7.0 Aug 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yaziine yaziine yaziine left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.7.0
Development

Successfully merging this pull request may close these issues.
2 participants
@asdine @yaziine