Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tables suggestion to the CLI #143

Closed
yaziine opened this issue Jul 30, 2020 · 2 comments · Fixed by #168
Closed

Add tables suggestion to the CLI #143

yaziine opened this issue Jul 30, 2020 · 2 comments · Fixed by #168
Labels
cli Command line enhancement New feature or request good first issue Good for newcomers
Milestone
v0.8.0

Comments

@yaziine
Copy link
Collaborator

yaziine commented Jul 30, 2020

After the FROM keyword, the cli should suggest us all existing tables.

genji> SELECT * FROM <suggestion of all existing tables>
@yaziine yaziine added enhancement New feature or request good first issue Good for newcomers cli Command line labels Jul 30, 2020
@tzzed
Copy link
Contributor

tzzed commented Aug 21, 2020

It will be nice to have the same behavior after DROP TABLE statement.

 genji> DROP TABLE <suggestion of all existing tables>

@tzzed tzzed mentioned this issue Aug 21, 2020
Merged
@yaziine
Copy link
Collaborator Author

yaziine commented Aug 25, 2020

It would be nice if we add the suggestions on all statement that require the FROM clause.
For example, in the ALTER and UPDATE ones.

@asdine asdine added this to the v0.8.0 milestone Aug 25, 2020
@tzzed tzzed mentioned this issue Aug 26, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
cli Command line enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
v0.8.0
Development

Successfully merging a pull request may close this issue.

Add tables suggestion to the CLI tzzed/genji
3 participants
@asdine @yaziine @tzzed