Table suggestion after FROM keyword #159

tzzed · 2020-08-21T20:50:44Z

This PR fixes the #143 .
Tables are listed after FROM keyword in SELECT and DELETE statements.
Added to DROP TABLE statement too.
If there is no tables the word table_name is displayed:

genji> SELECT * FROM table_name

asdine

Great job @tzzed! Just one comment about the error returned, the rest is fine

sql/parser/delete.go

sql/parser/drop.go

sql/parser/select.go

cmd/genji/shell/shell.go

asdine

Thank you!

And for DROP TABLE statement

asdine reviewed Aug 22, 2020

View reviewed changes

sql/parser/delete.go Outdated Show resolved Hide resolved

sql/parser/drop.go Outdated Show resolved Hide resolved

sql/parser/select.go Outdated Show resolved Hide resolved

cmd/genji/shell/shell.go Outdated Show resolved Hide resolved

tzzed requested a review from asdine August 24, 2020 11:22

asdine approved these changes Aug 24, 2020

View reviewed changes

tzzed added 3 commits August 24, 2020 17:42

Add tables suggestion after FROM keyword for SELECT, DELETE queries

0454f21

And for DROP TABLE statement

Add tables suggestion after FROM keyword

2e92535

Add review's suggestions.

f9639b4

tzzed force-pushed the table-suggestion branch from cdabd08 to f9639b4 Compare August 24, 2020 15:49

asdine merged commit 8fa24bf into chaisql:master Aug 24, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Table suggestion after FROM keyword #159

Table suggestion after FROM keyword #159

tzzed commented Aug 21, 2020

asdine left a comment

asdine left a comment

Table suggestion after FROM keyword #159

Table suggestion after FROM keyword #159

Conversation

tzzed commented Aug 21, 2020

asdine left a comment

Choose a reason for hiding this comment

asdine left a comment

Choose a reason for hiding this comment