Separate secp256k1 library calls into external gem

chaintope · Nov 13, 2024 · 8eeb14f · 8eeb14f
1 parent 8578bb6
commit 8eeb14f
Show file tree

Hide file tree

Showing 4 changed files with 69 additions and 366 deletions.
diff --git a/bitcoinrb.gemspec b/bitcoinrb.gemspec
@@ -36,4 +36,5 @@ Gem::Specification.new do |spec|
   spec.add_runtime_dependency 'base32', '>= 0.3.4'
   spec.add_runtime_dependency 'base64', '~> 0.2.0'
   spec.add_runtime_dependency 'observer', '~> 0.1.2'
+  spec.add_runtime_dependency 'secp256k1rb', '0.1.0'
 end
diff --git a/lib/bitcoin/bip324.rb b/lib/bitcoin/bip324.rb
@@ -132,7 +132,7 @@ def v2_ecdh(priv_key, ellswift_theirs, ellswift_ours, initiating)
       raise ArgumentError, "ellswift_ours must be a Bitcoin::BIP324::EllSwiftPubkey" unless ellswift_ours.is_a?(Bitcoin::BIP324::EllSwiftPubkey)
 
       if Bitcoin.secp_impl.is_a?(Bitcoin::Secp256k1::Native)
-        Bitcoin::Secp256k1::Native.ellswift_ecdh_xonly(ellswift_theirs, ellswift_ours, priv_key, initiating)
+        Bitcoin::Secp256k1::Native.ellswift_ecdh_xonly(ellswift_theirs.key, ellswift_ours.key, priv_key, initiating)
       else
         ecdh_point_x32 = ellswift_ecdh_xonly(ellswift_theirs, priv_key).htb
         content = initiating ? ellswift_ours.key + ellswift_theirs.key + ecdh_point_x32 :