Fix a bug in Bitcoin::MessageSign#verify_message where the BIP322 che…

…ck was always true
chaintope · Aug 17, 2024 · 0223415 · 0223415
1 parent 433c238
commit 0223415
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/lib/bitcoin/message_sign.rb b/lib/bitcoin/message_sign.rb
@@ -71,7 +71,8 @@ def verify_message(address, signature, message, prefix: Bitcoin.chain_params.mes
         tx.in[0].script_witness = Bitcoin::ScriptWitness.parse_from_payload(sig)
         script_pubkey = Bitcoin::Script.parse_from_addr(address)
         tx_out = Bitcoin::TxOut.new(script_pubkey: script_pubkey)
-        interpreter = Bitcoin::ScriptInterpreter.new(checker: Bitcoin::TxChecker.new(tx: tx, input_index: 0, prevouts: [tx_out]))
+        flags = Bitcoin::STANDARD_SCRIPT_VERIFY_FLAGS
+        interpreter = Bitcoin::ScriptInterpreter.new(flags: flags, checker: Bitcoin::TxChecker.new(tx: tx, input_index: 0, prevouts: [tx_out]))
         interpreter.verify_script(Bitcoin::Script.new, script_pubkey, tx.in[0].script_witness)
       else
         raise ArgumentError, "This address unsupported."

diff --git a/spec/bitcoin/message_sign_spec.rb b/spec/bitcoin/message_sign_spec.rb
@@ -129,6 +129,7 @@
       # Verify signature
       expect(described_class.verify_message(addr, sig1, '')).to be true
       expect(described_class.verify_message(addr, sig2, 'Hello World')).to be true
+      expect(described_class.verify_message(addr, sig2, 'Hello World2')).to be false
     end
   end