-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(integration): guacsec/guac integration #211
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Miguel Martinez Trivino <[email protected]>
Signed-off-by: Miguel Martinez Trivino <[email protected]>
migmartri
changed the title
feat(integration): guac GCP integration
feat(integration): guacsec/guac integration
Jun 28, 2023
Signed-off-by: Miguel Martinez Trivino <[email protected]>
6 tasks
danlishka
reviewed
Jun 28, 2023
danlishka
reviewed
Jun 28, 2023
danlishka
reviewed
Jun 28, 2023
danlishka
reviewed
Jun 28, 2023
danlishka
reviewed
Jun 28, 2023
danlishka
reviewed
Jun 28, 2023
danlishka
reviewed
Jun 28, 2023
danlishka
reviewed
Jun 28, 2023
danlishka
reviewed
Jun 28, 2023
danlishka
reviewed
Jun 28, 2023
danlishka
reviewed
Jun 28, 2023
Great review @danlishka! I'll tackle most of your comments! Stay tuned! Thanks! |
Signed-off-by: Miguel Martinez Trivino <[email protected]>
Signed-off-by: Miguel Martinez Trivino <[email protected]>
migmartri
commented
Jun 28, 2023
Signed-off-by: Miguel Martinez Trivino <[email protected]>
Signed-off-by: Miguel Martinez Trivino <[email protected]>
danlishka
approved these changes
Jun 28, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Integration that allows Chainloop users to automatically send attestation (
DSSE
envelopes /in-toto
statements) and CycloneDX/SPDX Software Bill Of Materials (SBOMs) to a staging area in the form of a cloud storage bucket. GUAC then can be configured to continuously monitor and inject the data in that bucket.See this Readme for more information.
Currently,
Guac
only support Google Cloud Storage (GCS) as blob storage backend. So this patch only implements this provider although leaves the API open to other providers in the future.Discovery
The plugin is now available in the system
And it's definition can be retrieved showing that today it sends both SBOM types
Registration
Registration by providing a bucket and service account credentials, provider can be sent as well although by default the only option we have now is
gcs
.$ chainloop integration registered add guac --opt bucket=test-guac --opt credentials="$(cat /service-account-devel.json)" ┌──────────────────────────────────────┬─────────────┬──────┬───────────────────┬─────────────────────┐ │ ID │ DESCRIPTION │ KIND │ CONFIG │ CREATED AT │ ├──────────────────────────────────────┼─────────────┼──────┼───────────────────┼─────────────────────┤ │ d19dabf0-d6dd-4f00-91c0-eed209454d05 │ │ guac │ bucket: test-guac │ 28 Jun 23 14:23 UTC │ │ │ │ │ provider: gcs │ │ └──────────────────────────────────────┴─────────────┴──────┴───────────────────┴─────────────────────┘
Attachment
It does not require any options
Execution
Demo
Closes #209